gas dimension tracing: write disk in sync batches, access list tracer

This commit deletes the async vibe coded solution for writing
transactions to disk in favor of writing them to disk synchronously in
batches of 1000 instead. It also replaces calls out to the statedb in
favor of using the logger.AccessListTracer which maintains a duplicate
parallel copy of the access list but also stores it in a map for faster
lookup. Hopefully these efforts help performance of the live tracer to
stay synced to the tip of the chain :(

Author: relyt29

eth/tracers/live/tx_gas_dimension.go

@@ -46,6 +46,12 @@ func (al accessList) addAddress(address common.Address) {
 	}
 }
 
+// hasAddress checks if an address is in the accesslist.
+func (al accessList) hasAddress(address common.Address) bool {
+	_, ok := al[address]
+	return ok
+}
+
 // addSlot adds a storage slot to the accesslist.
 func (al accessList) addSlot(address common.Address, slot common.Hash) {
 	// Set address if not previously present
@@ -55,6 +61,12 @@ func (al accessList) addSlot(address common.Address, slot common.Hash) {
 	al[address][slot] = struct{}{}
 }
 
+// hasSlot checks if a storage slot is in the accesslist.
+func (al accessList) hasSlot(address common.Address, slot common.Hash) bool {
+	_, ok := al[address][slot]
+	return ok
+}
+
 // equal checks if the content of the current access list is the same as the
 // content of the other one.
 func (al accessList) equal(other accessList) bool {
@@ -157,3 +169,13 @@ func (a *AccessListTracer) AccessList() types.AccessList {
 func (a *AccessListTracer) Equal(other *AccessListTracer) bool {
 	return a.list.equal(other.list)
 }
+
+// HasAddress checks if an address is in the accesslist.
+func (a *AccessListTracer) HasAddress(address common.Address) bool {
+	return a.list.hasAddress(address)
+}
+
+// HasSlot checks if a storage slot is in the accesslist.
+func (a *AccessListTracer) HasSlot(address common.Address, slot common.Hash) bool {
+	return a.list.hasSlot(address, slot)
+}

eth/tracers/live/tx_gas_dimension_test.go

@@ -12,6 +12,7 @@ import (
 	"github.com/ethereum/go-ethereum/core/tracing"
 	"github.com/ethereum/go-ethereum/core/types"
 	"github.com/ethereum/go-ethereum/core/vm"
+	"github.com/ethereum/go-ethereum/eth/tracers/logger"
 	"github.com/ethereum/go-ethereum/params"
 )
 
@@ -46,8 +47,7 @@ type BaseGasDimensionTracer struct {
 	// if the root is a stylus contract
 	rootIsStylusAdjustment uint64
 	// maintain an access list tracer to check previous access list statuses.
-	prevAccessListAddresses map[common.Address]int
-	prevAccessListSlots     []map[common.Hash]struct{}
+	accessListTracer *logger.AccessListTracer
 	// the amount of refund accumulated at the current step of execution
 	refundAccumulated uint64
 	// in order to calculate the refund adjusted, we need to know the total execution gas
@@ -85,13 +85,13 @@ func NewBaseGasDimensionTracer(cfg json.RawMessage, chainConfig *params.ChainCon
 		}
 		debug = config.Debug
 	}
+	accessListTracer := logger.NewAccessListTracer(types.AccessList{}, map[common.Address]struct{}{})
 	return &BaseGasDimensionTracer{
 		debug:                       debug,
 		chainConfig:                 chainConfig,
 		depth:                       1,
 		refundAccumulated:           0,
-		prevAccessListAddresses:     map[common.Address]int{},
-		prevAccessListSlots:         []map[common.Hash]struct{}{},
+		accessListTracer:            accessListTracer,
 		env:                         nil,
 		txHash:                      common.Hash{},
 		gasUsed:                     0,
@@ -277,18 +277,6 @@ func (t *BaseGasDimensionTracer) updateCallChildExecutionCost(cost uint64) {
 	}
 }
 
-// at the end of each OnOpcode, update the previous access list, so that we can
-// use it should the next opcode need to check if an address is in the access list
-func (t *BaseGasDimensionTracer) updatePrevAccessList(addresses map[common.Address]int, slots []map[common.Hash]struct{}) {
-	if addresses == nil {
-		t.prevAccessListAddresses = map[common.Address]int{}
-		t.prevAccessListSlots = []map[common.Hash]struct{}{}
-		return
-	}
-	t.prevAccessListAddresses = addresses
-	t.prevAccessListSlots = slots
-}
-
 // OnTxStart handles transaction start
 func (t *BaseGasDimensionTracer) OnTxStart(env *tracing.VMContext, tx *types.Transaction, from common.Address) {
 	t.env = env
@@ -396,9 +384,9 @@ func (t *BaseGasDimensionTracer) GetRootIsStylus() bool {
 	return t.rootIsStylus
 }
 
-// GetPrevAccessList returns the previous access list
-func (t *BaseGasDimensionTracer) GetPrevAccessList() (addresses map[common.Address]int, slots []map[common.Hash]struct{}) {
-	return t.prevAccessListAddresses, t.prevAccessListSlots
+// GetAccessListTracer returns the access list tracer
+func (t *BaseGasDimensionTracer) GetAccessListTracer() *logger.AccessListTracer {
+	return t.accessListTracer
 }
 
 // GetPrecompileAddressList returns the list of precompile addresses

eth/tracers/logger/access_list_tracer.go

@@ -8,6 +8,7 @@ import (
 	"github.com/ethereum/go-ethereum/core/state"
 	"github.com/ethereum/go-ethereum/core/tracing"
 	"github.com/ethereum/go-ethereum/core/vm"
+	"github.com/ethereum/go-ethereum/eth/tracers/logger"
 	"github.com/ethereum/go-ethereum/params"
 )
 
@@ -100,7 +101,7 @@ type DimensionTracer interface {
 	GetOpRefund() uint64
 	GetRefundAccumulated() uint64
 	SetRefundAccumulated(uint64)
-	GetPrevAccessList() (addresses map[common.Address]int, slots []map[common.Hash]struct{})
+	GetAccessListTracer() *logger.AccessListTracer
 	GetPrecompileAddressList() []common.Address
 	GetStateDB() tracing.StateDB
 	GetCallStack() CallGasDimensionStack
@@ -1209,9 +1210,8 @@ func memoryGasCost(mem []byte, lastGasCost uint64, newMemSize uint64) (fee uint6
 
 // helper function that calculates the gas dimensions for an access list access for an address
 func addressAccessListCost(t DimensionTracer, address common.Address) (computationGasCost uint64, stateAccessGasCost uint64) {
-	accessListAddresses, _ := t.GetPrevAccessList()
-	_, addressInAccessList := accessListAddresses[address]
-	if !addressInAccessList {
+	accessListTracer := t.GetAccessListTracer()
+	if !accessListTracer.HasAddress(address) {
 		computationGasCost = params.WarmStorageReadCostEIP2929
 		stateAccessGasCost = params.ColdAccountAccessCostEIP2929 - params.WarmStorageReadCostEIP2929
 	} else {
@@ -1222,22 +1222,17 @@ func addressAccessListCost(t DimensionTracer, address common.Address) (computati
 }
 
 // helper function that calculates the gas dimensions for an access list access for a storage slot
-func storageSlotAccessListCost(t DimensionTracer, address common.Address, slot common.Hash) (computationGasCost uint64, stateAccessGasCost uint64) {
-	accessListAddresses, accessListSlots := t.GetPrevAccessList()
-	idx, ok := accessListAddresses[address]
-	if !ok {
-		// no such address (and hence zero slots)
-		return params.WarmStorageReadCostEIP2929, params.ColdSloadCostEIP2929 - params.WarmStorageReadCostEIP2929
-	}
-	if idx == -1 {
-		// address yes, but no slots
-		return params.WarmStorageReadCostEIP2929, params.ColdSloadCostEIP2929 - params.WarmStorageReadCostEIP2929
-	}
-	_, slotPresent := accessListSlots[idx][slot]
-	if !slotPresent {
-		return params.WarmStorageReadCostEIP2929, params.ColdSloadCostEIP2929 - params.WarmStorageReadCostEIP2929
+func storageSlotAccessListCost(t DimensionTracer, address common.Address, slot common.Hash) (
+	computationGasCost uint64, stateAccessGasCost uint64) {
+	accessListTracer := t.GetAccessListTracer()
+	if !accessListTracer.HasSlot(address, slot) {
+		computationGasCost = params.WarmStorageReadCostEIP2929
+		stateAccessGasCost = params.ColdSloadCostEIP2929 - params.WarmStorageReadCostEIP2929
+	} else {
+		computationGasCost = params.WarmStorageReadCostEIP2929
+		stateAccessGasCost = 0
 	}
-	return params.WarmStorageReadCostEIP2929, 0
+	return computationGasCost, stateAccessGasCost
 }
 
 // wherever it's possible, check that the gas dimensions are sane