do not panic for nil chain id

amsanghi · amsanghi · commit dd527528c8d0 · 2025-05-09T15:44:13.000+05:30
diff --git a/core/types/transaction_signing.go b/core/types/transaction_signing.go
@@ -206,8 +206,8 @@ type modernSigner struct {
 }
 
 func newModernSigner(chainID *big.Int, fork forks.Fork) Signer {
-	if chainID == nil || chainID.Sign() <= 0 {
-		panic(fmt.Sprintf("invalid chainID %v", chainID))
+	if chainID == nil {
+		chainID = new(big.Int)
 	}
 	s := &modernSigner{
 		chainID: chainID,

Original file line number	Diff line number	Diff line change
`@@ -206,8 +206,8 @@ type modernSigner struct {`
`206`	`206`	`}`
`207`	`207`
`208`	`208`	`func newModernSigner(chainID *big.Int, fork forks.Fork) Signer {`
`209`		`- if chainID == nil \|\| chainID.Sign() <= 0 {`
`210`		`- panic(fmt.Sprintf("invalid chainID %v", chainID))`
	`209`	`+ if chainID == nil {`
	`210`	`+ chainID = new(big.Int)`
`211`	`211`	`}`
`212`	`212`	`s := &modernSigner{`
`213`	`213`	`chainID: chainID,`