Merge pull request #448 from OffchainLabs/large-maxgas

joshuacolvin0 · web-flow · commit f40a18e3c41b · 2025-05-02T12:18:11.000-07:00
Avoid overflow when adding additional gas
diff --git a/internal/ethapi/api.go b/internal/ethapi/api.go
@@ -721,7 +721,9 @@ func applyMessage(ctx context.Context, b Backend, args TransactionArgs, state *s
 		if err != nil {
 			return nil, err
 		}
-		gp.AddGas(postingGas)
+		if gp.Gas() < gomath.MaxUint64-postingGas {
+			gp.AddGas(postingGas)
+		}
 	}
 	if msg.GasLimit > gp.Gas() {
 		gp.SetGas(msg.GasLimit)

Original file line number	Diff line number	Diff line change
`@@ -721,7 +721,9 @@ func applyMessage(ctx context.Context, b Backend, args TransactionArgs, state *s`
`721`	`721`	`if err != nil {`
`722`	`722`	`return nil, err`
`723`	`723`	`}`
`724`		`- gp.AddGas(postingGas)`
	`724`	`+ if gp.Gas() < gomath.MaxUint64-postingGas {`
	`725`	`+ gp.AddGas(postingGas)`
	`726`	`+ }`
`725`	`727`	`}`
`726`	`728`	`if msg.GasLimit > gp.Gas() {`
`727`	`729`	`gp.SetGas(msg.GasLimit)`