Skip to content

return missing targets when handling wasm activations in statedb #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jul 11, 2025
Merged

return missing targets when handling wasm activations in statedb #468

merged 16 commits into from
Jul 11, 2025

Conversation

magicxyyz
Copy link
Contributor

@magicxyyz magicxyyz commented Jun 13, 2025 •
edited
Loading

part of NIT-3358

In this PR:

  • StateDB method that gets asmMap (target to assembly map), for given module hash and target list, is modified to return list of targets for which assembly data was not found
  • In ActivateWasm, safety check is added that ensures that newly activated asmMaps contain entries for the same target list
  • Cleans up error and "not found" handling when reading from wasm store

@cla-bot cla-bot bot added the s CLA signed label Jun 13, 2025
@magicxyyz magicxyyz mentioned this pull request Jun 13, 2025
Merged
@magicxyyz magicxyyz self-assigned this Jun 13, 2025
@magicxyyz magicxyyz force-pushed the wasm-rebuild-missing-targets branch from 687c803 to 4d9d66a Compare June 16, 2025 19:22
@magicxyyz magicxyyz changed the base branch from master to run-mode-struct June 16, 2025 19:22
@magicxyyz magicxyyz requested review from amsanghi and gligneul June 20, 2025 22:32
@magicxyyz magicxyyz removed their assignment Jun 20, 2025
@magicxyyz magicxyyz marked this pull request as ready for review June 20, 2025 22:33
@magicxyyz magicxyyz self-assigned this Jun 20, 2025
@magicxyyz magicxyyz marked this pull request as draft June 20, 2025 22:35
@magicxyyz magicxyyz marked this pull request as ready for review June 27, 2025 18:50
@magicxyyz magicxyyz removed their assignment Jun 27, 2025
Base automatically changed from run-mode-struct to master June 27, 2025 19:13
@tsahee tsahee assigned gligneul and unassigned amsanghi Jun 30, 2025
tsahee
tsahee reviewed Jun 30, 2025
View reviewed changes
Copy link
Collaborator

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment

gligneul
gligneul previously requested changes Jun 30, 2025
View reviewed changes
Copy link
Contributor

@gligneul gligneul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just minor comments.

@gligneul gligneul removed their assignment Jun 30, 2025
tsahee
tsahee requested changes Jul 11, 2025
View reviewed changes
Copy link
Collaborator

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just that log.Crit

@magicxyyz magicxyyz requested a review from tsahee July 11, 2025 20:03
@magicxyyz magicxyyz assigned tsahee and unassigned magicxyyz Jul 11, 2025
@tsahee tsahee merged commit aa55512 into master Jul 11, 2025
15 checks passed
@tsahee tsahee deleted the wasm-rebuild-missing-targets branch July 11, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsahee tsahee tsahee approved these changes

@gligneul gligneul gligneul left review comments

@amsanghi amsanghi Awaiting requested review from amsanghi

Assignees

@tsahee tsahee

Labels
design-approved s CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@magicxyyz @gligneul @tsahee @amsanghi