Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced Handling of Missing tvdb_id in Ombi Requests #5214

Open
Unimatrix0 opened this issue Jan 15, 2025 · 0 comments
Open

Enhanced Handling of Missing tvdb_id in Ombi Requests #5214

Unimatrix0 opened this issue Jan 15, 2025 · 0 comments

Comments

@Unimatrix0
Copy link
Contributor

Unimatrix0 commented Jan 15, 2025

Summary

Add functionality to handle missing tvdb_id scenarios in Ombi more effectively, allowing admins and power users (PU+) to address the issue without resorting to manual intervention in Sonarr or other external tools.


Proposed Features:

  1. Detection and Early Warning:

    • Detect missing tvdb_id earlier in the request process (e.g., when fetching data from TheMovieDB).
    • Display a warning to users when a tvdb_id is missing, explaining the issue and its implications.
  2. Request Flow Adjustments:

    • If the user is a standard user:
      • Show a warning and encourage user to validate they have selected the correct series.
      • Allow the request to proceed but move it to the "Pending" queue (regardless of User's AutoApprove permissions) with a notification to the admin about the missing tvdb_id.
    • If the user is PU+:
      • Show a warning and provide a field to manually input the tvdb_id before submitting the request.
      • Include validation to ensure the entered tvdb_id is valid.
      • If the user does not fill in a valid tvdb_id, allow the request to proceed but move it to the "Pending" queue (regardless of user's AutoApprove permissions) with a notification to the admin about the missing tvdb_id.
  3. Admin Notification and Fix Options:

    • Notify admins when a request with a missing tvdb_id is submitted.
    • Allow admins to edit the request, add the missing tvdb_id, and retry processing the request directly from Ombi.
  4. Improved User Messaging:

    • Show non-PU+ users a validation warning when selecting series with multiple entries in TheMovieDB, encouraging them to confirm the correct selection.
    • Use the same warning for PU+ users, emphasizing the importance of ensuring accurate data.
  5. Optional filter for Missing tvdb_id Requests:

    • Create a "Missing tvdb_id" filter for the Pending queue where requests with missing IDs are held until resolved by an admin or PU+.
    • This queue would allow for centralized management of such requests, reducing confusion and ensuring consistent handling.
  6. Optional API Enhancements:

    • Explore the possibility of allowing Ombi to update TheMovieDB with the missing tvdb_id if provided by the user. This feature would require:
      • Admin or user-provided API keys for TheMovieDB.
      • Clear warnings about the risks and responsibilities of allowing user-submitted updates with an admin-provided API key.

Benefits:

  • Reduces admin reliance on external tools like Sonarr for resolving missing tvdb_id issues.
  • Empowers power users to resolve issues independently, reducing admin workload.
  • Improves transparency and user experience by clearly communicating the problem and its resolution process.
  • Helps mitigate confusion caused by missing data and ensures smoother request handling.

Considerations:

  • Develop clear and unambiguous warning messages that do not further confuse users.
  • Ensure robust validation of manually entered tvdb_id values to prevent errors.
  • Clearly communicate to admins the risks of enabling user updates to TheMovieDB via their API keys.
  • Evaluate the effort-to-benefit ratio for implementing optional features like TheMovieDB updates.

This feature aims to address increasing instances of missing tvdb_id errors, streamline the resolution process, and improve overall user satisfaction with Ombi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants