Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GpsProcessing : refactor out SentinelHub logic #249

Open
soxofaan opened this issue Oct 20, 2022 · 0 comments
Open

GpsProcessing : refactor out SentinelHub logic #249

soxofaan opened this issue Oct 20, 2022 · 0 comments

Comments

@soxofaan
Copy link
Member

GpsProcessing (in backend.py) has a lot of SentinelHub details woven in, with a lot of nested functions and classes. This makes it hard to maintain and write tests for. As noted in code itself:

# TODO: encapsulate this SHub stuff in a dedicated class?
def _scheduled_sentinelhub_batch_processes(self, process_graph: dict, api_version: Union[str, None],
job_registry: JobRegistry, user_id: str, job_id: str,

Example: as (quick)fix for #248 I added

elif isinstance(geometries, DriverVectorCube):
# TODO: only area of covered regions instead of whole bbox area?
return geometries.get_bounding_box_area()
but I couldn't figure out an easy way to cover that with a unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant