Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async_task: avoid false negative JobNotFoundException #289

Open
bossie opened this issue Dec 13, 2022 · 0 comments
Open

async_task: avoid false negative JobNotFoundException #289

bossie opened this issue Dec 13, 2022 · 0 comments

Comments

@bossie
Copy link
Collaborator

bossie commented Dec 13, 2022

Commit dfe465a for #240 added these lines to avoid failing and reporting an (expected) error when a user decided to delete his batch job while async_task is actively polling SHub:

except JobNotFoundException as e:
# TODO: look for "Deleted ..." log entry in Elasticsearch to avoid a false negative?
_log.warning("job not found; assuming user deleted it in the meanwhile", exc_info=True,
extra={'job_id': e.job_id})

This approach is maybe too drastic and could cover up an unexpected JobNotFoundException.

The batch job itself is obviously gone and the only way to tell if the user actually deleted it himself is by inspecting the logs in ES.

Cost-benefit etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant