Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an interactive getting started guide for the Web Editor #172

Open
m-mohr opened this issue Jul 12, 2021 · 4 comments
Open

Implement an interactive getting started guide for the Web Editor #172

m-mohr opened this issue Jul 12, 2021 · 4 comments
Assignees
Milestone

Comments

@m-mohr
Copy link
Member

m-mohr commented Jul 12, 2021

Something like https://github.com/pulsardev/vue-tour

@m-mohr m-mohr modified the milestones: v0.8.0, v0.9.0 Jul 12, 2021
m-mohr added a commit that referenced this issue Aug 4, 2021
m-mohr added a commit that referenced this issue Aug 4, 2021
m-mohr added a commit that referenced this issue Aug 4, 2021
@m-mohr m-mohr modified the milestones: v0.9.0, v0.10.0 Aug 30, 2021
@m-mohr
Copy link
Member Author

m-mohr commented Sep 7, 2021

The tour related to OIDC login needs to be a bit more fine-grained. Especially, we would want to explain the Client ID field if it is shown.

@christophfriedrich is right with his comment though, so we need to find a solution later:

I can try whether I can detect whether there is OIDC auth on the current server or not, but at the moment I wouldn't know how to do this in Tour.vue 🤔 Is this info available via some this. variable?

Can you provide me with an explanation you would like to see for Client ID? I don't know too much about it myself...

See also: #199 (comment)

@christophfriedrich
Copy link
Collaborator

The info is indirectly available by querying the DOM for whether the corresponding UI elements are there. Not the nicest way, but works.

if (document.querySelector(this.entries['login-internal'].target) !== null) { // server has basic auth

which is

if (document.querySelector('#credentials > .tabsHeader > button[title=Internal]') !== null) {

Another way of doing this:

if (Array.from(document.getElementsByTagName('button')).some(e => e.title == 'Internal')) {

@m-mohr
Copy link
Member Author

m-mohr commented Sep 8, 2021

Open issue reported by @christophfriedrich:

The only issue I still encountered and can't really think of a way to fix: When a user is on the e.g. "Internal" tab, starts the tour, and then switches over to "No credentials", the tour crashes because the step for the input fields (login-credentials) was already loaded, but the target has since been removed from the DOM...

@m-mohr
Copy link
Member Author

m-mohr commented Nov 19, 2021

esa requests a tour for the data processing / batch job area.

@m-mohr m-mohr modified the milestones: v0.10, v0.11 Dec 16, 2021
@m-mohr m-mohr self-assigned this Feb 4, 2022
@m-mohr m-mohr modified the milestones: v0.11, v1.0 Apr 7, 2022
@m-mohr m-mohr removed their assignment Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants