From b0f86e06770d1dffd65e0a177b666fb9e8aabd7b Mon Sep 17 00:00:00 2001 From: kasthur Date: Thu, 21 Feb 2019 10:20:23 +0530 Subject: [PATCH 1/4] fixed test classes --- .../transaction/MonetaryTransactionsServiceTest.java | 2 +- .../java/com/tesobe/obp/user/EntitlementsTest.java | 11 +++++++++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/test/java/com/tesobe/obp/transaction/MonetaryTransactionsServiceTest.java b/src/test/java/com/tesobe/obp/transaction/MonetaryTransactionsServiceTest.java index f9d5622..215dcab 100644 --- a/src/test/java/com/tesobe/obp/transaction/MonetaryTransactionsServiceTest.java +++ b/src/test/java/com/tesobe/obp/transaction/MonetaryTransactionsServiceTest.java @@ -35,7 +35,7 @@ public void fetchTransactionListOk() throws Exception { TransactionRequest transactionRequest = new TransactionRequest( new TransactionRequest.DestAccount(bankId, accountIdOne), Money.of(CurrencyUnit.EUR, 5), "some description"); - String result = obpApiClient.initiateTransaction(bankId, accounts.get(1).getId(), "SANDBOX_TAN", transactionRequest); + String result = obpApiClient.initiateTransaction(bankId, accounts.get(0).getId(), "SANDBOX_TAN", transactionRequest); List transactions = obpApiClient.getTransactionsForAccount(bankId, accountIdOne).getTransactions(); Assert.assertTrue(transactions.size() > 0); diff --git a/src/test/java/com/tesobe/obp/user/EntitlementsTest.java b/src/test/java/com/tesobe/obp/user/EntitlementsTest.java index 4e691ca..ff6eaa7 100644 --- a/src/test/java/com/tesobe/obp/user/EntitlementsTest.java +++ b/src/test/java/com/tesobe/obp/user/EntitlementsTest.java @@ -15,7 +15,14 @@ public class EntitlementsTest extends AbstractTestSupport { @Test public void entitlementsUser() throws Exception { - String entz = entitlementsApiClient.getEntitlements(user); - Assert.assertNotNull(entz); + try { + + String entz = entitlementsApiClient.getEntitlements(user); + + Assert.assertNotNull(entz); + } + catch (Exception ex) { + ex.printStackTrace(); + } } } From 4184c7fee92a889c76dbb25a1d413476ecc7ddd9 Mon Sep 17 00:00:00 2001 From: kasthur Date: Thu, 21 Feb 2019 10:22:09 +0530 Subject: [PATCH 2/4] fixed test classes --- src/main/resources/application.properties | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/main/resources/application.properties b/src/main/resources/application.properties index 3385190..d60684a 100644 --- a/src/main/resources/application.properties +++ b/src/main/resources/application.properties @@ -1,13 +1,12 @@ obp.api.rootUrl=https://apisandbox.openbankproject.com -obp.api.versionedUrl:${obp.api.rootUrl}/obp/v3.1.0 +obp.api.versionedUrl:${obp.api.rootUrl}/obp/v2.2.0 obp.api.directloginUrl=${obp.api.rootUrl}/my/logins/direct obp.api.directLoginPath=/my/logins/direct -obp.consumerKey=mohge1sdpcssyqwoygsaokfaycayqsrgqcg4o023 +obp.consumerKey=pfemfxpuxwm3ew2eq5fcey3liyfapgnv3yvlsrkj //we are using multiple @FeignClient beans and without bean overriding the app fails to start. \ see https://stackoverflow.com/questions/53787550/jpaauditinghandler-defined-in-null-on-application-startup-using-spring-boot spring.main.allow-bean-definition-overriding=true - From ac803d5c2c3ecb8c5da18eb1f3093a3a2ad39396 Mon Sep 17 00:00:00 2001 From: kasthur Date: Thu, 21 Feb 2019 14:21:24 +0530 Subject: [PATCH 3/4] fixed test class --- .../com/tesobe/obp/user/EntitlementsTest.java | 22 ++++++++----------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/src/test/java/com/tesobe/obp/user/EntitlementsTest.java b/src/test/java/com/tesobe/obp/user/EntitlementsTest.java index ff6eaa7..b26b868 100644 --- a/src/test/java/com/tesobe/obp/user/EntitlementsTest.java +++ b/src/test/java/com/tesobe/obp/user/EntitlementsTest.java @@ -9,20 +9,16 @@ public class EntitlementsTest extends AbstractTestSupport { - @Value("${obp.username}") - private String user; - @Autowired private EntitlementsApiClient entitlementsApiClient; + @Value("${obp.username}") + private String user; + @Autowired + private EntitlementsApiClient entitlementsApiClient; - @Test - public void entitlementsUser() throws Exception { - try { + @Test + public void entitlementsUser() throws Exception { - String entz = entitlementsApiClient.getEntitlements(user); + String entz = entitlementsApiClient.getEntitlements(user); - Assert.assertNotNull(entz); - } - catch (Exception ex) { - ex.printStackTrace(); - } - } + Assert.assertNotNull(entz); + } } From 2792add9b7ee724c7d41ac2b4ce2f32302cca513 Mon Sep 17 00:00:00 2001 From: kasthur Date: Thu, 21 Feb 2019 14:57:33 +0530 Subject: [PATCH 4/4] updated obp version to 3.1.0 --- src/main/resources/application.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/resources/application.properties b/src/main/resources/application.properties index d60684a..06873e9 100644 --- a/src/main/resources/application.properties +++ b/src/main/resources/application.properties @@ -1,6 +1,6 @@ obp.api.rootUrl=https://apisandbox.openbankproject.com -obp.api.versionedUrl:${obp.api.rootUrl}/obp/v2.2.0 +obp.api.versionedUrl:${obp.api.rootUrl}/obp/v3.1.0 obp.api.directloginUrl=${obp.api.rootUrl}/my/logins/direct obp.api.directLoginPath=/my/logins/direct