Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only one concrete base type per class #353

Closed
pavel-kirienko opened this issue Apr 24, 2024 · 1 comment
Closed

Only one concrete base type per class #353

pavel-kirienko opened this issue Apr 24, 2024 · 1 comment
Assignees
@serges147
Labels
class-requirement Issue that can be traced back to a design requiement domain-production Pertains to the shippable code rather than any scaffolding

Comments

@pavel-kirienko
Copy link
Member

It's important we adhere to the "only one concrete base type per class" rule. That is, no type shall extend more than a single class that has non-pure-virtual methods or data-members. That means there isn't a "sorta an interface" type in this stack. We only have classes and interfaces and the latter has no data members and only pure-virtual methods.

Originally posted by @thirtytwobits in #347 (comment)
@pavel-kirienko pavel-kirienko added domain-production Pertains to the shippable code rather than any scaffolding class-requirement Issue that can be traced back to a design requiement labels Apr 24, 2024
@pavel-kirienko pavel-kirienko mentioned this issue Apr 25, 2024
Merged
@serges147
Copy link
Collaborator

@pavel-kirienko I think this issue has been addressed. Would you agree?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serges147 serges147

Labels
class-requirement Issue that can be traced back to a design requiement domain-production Pertains to the shippable code rather than any scaffolding
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@serges147 @pavel-kirienko