Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAN TX pipeline is broken after recent refactoring to use new canardTxPoll api. #438

Closed
serges147 opened this issue Feb 6, 2025 · 1 comment
Closed

CAN TX pipeline is broken after recent refactoring to use new canardTxPoll api. #438

serges147 opened this issue Feb 6, 2025 · 1 comment
Assignees
@serges147

Comments

@serges147
Copy link
Collaborator

media.tx_callback().reset(); was lost during the refactoring - as result constant polling even when TX queue is already empty.
@serges147 serges147 self-assigned this Feb 6, 2025
@serges147 serges147 mentioned this issue Feb 6, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 7, 2025
@serges147
Fixed CAN transport media TX callback lifetime. (#437)
a3be9d3 
Fix for issue #438:
- Fixed callback lifetime bug in CAN transport; added unit test to
specifically verify TX media callback lifetime.
- Although there is no such issue at UDP transport, still added similar
test for udp as well.
@serges147
Copy link
Collaborator Author

Fixed by pr #437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serges147 serges147

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@serges147