Description
Several UEFI specification-defined constants are currently defined locally in patina crates rather than being sourced from r-efi. These should be upstreamed to r-efi so they are available to the broader UEFI Rust ecosystem.
From PR #1447 review:
"for these various UEFI spec defined things, we should be taking them to r-efi as well. Hosting them here until they are merged there is fine."
Constants to upstream
The following constants are defined in patina but belong in r-efi:
Boot Manager (patina_boot::helpers)
LOAD_OPTION_ACTIVE (0x00000001) — EFI_LOAD_OPTION Attributes (UEFI Spec Section 3.1.3)
BOOT_ORDER_VARIABLE_NAME — BootOrder null-terminated UTF-16 variable name
- Boot#### variable name format
Other areas (audit needed)
EFI_GLOBAL_VARIABLE GUID (may already be in r-efi)
EVENT_GROUP_END_OF_DXE GUID
EVENT_GROUP_READY_TO_BOOT GUID
- SMBIOS-related constants in
patina_smbios
- Any other UEFI spec-defined values used across patina crates
Action Items
- Audit patina crates for locally-defined UEFI spec constants
- Check which ones already exist in
r-efi
- Submit PRs to r-efi/r-efi for missing constants
- Once merged and released, update patina to use
r-efi definitions
References
Description
Several UEFI specification-defined constants are currently defined locally in patina crates rather than being sourced from
r-efi. These should be upstreamed tor-efiso they are available to the broader UEFI Rust ecosystem.From PR #1447 review:
Constants to upstream
The following constants are defined in patina but belong in
r-efi:Boot Manager (
patina_boot::helpers)LOAD_OPTION_ACTIVE(0x00000001) — EFI_LOAD_OPTION Attributes (UEFI Spec Section 3.1.3)BOOT_ORDER_VARIABLE_NAME—BootOrdernull-terminated UTF-16 variable nameOther areas (audit needed)
EFI_GLOBAL_VARIABLEGUID (may already be in r-efi)EVENT_GROUP_END_OF_DXEGUIDEVENT_GROUP_READY_TO_BOOTGUIDpatina_smbiosAction Items
r-efir-efidefinitionsReferences