Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worked on Issue 1307 #1363

Closed

Conversation

nneni
Copy link
Contributor

@nneni nneni commented Oct 20, 2024

Description

I worked on issue 1307 and modified how the system handles range checks for meter readings in OED. Before, if a reading was outside the set range, all the readings in the batch were rejected but now the selective rejection is allowed. Database schema was updated as well as test cases.

Fixes #1307

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

@huss
Copy link
Member

huss commented Oct 30, 2024

This is to note that I have discussed the PR with the developer. @nneni is working with a team to address issues #1307. They have decided to close the draft PRs, work to create a single, comprehensive version and then submit a new PR. As such, this PR is desired to be closed and I am doing this.

@huss huss closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable reading rejection if outside bounds & work with units
2 participants