Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

excessive redraws of graphic pages #1420

Open
huss opened this issue Feb 3, 2025 · 0 comments
Open

excessive redraws of graphic pages #1420

huss opened this issue Feb 3, 2025 · 0 comments
Labels
p-high-priority This issue should be the focus of design and developement effort. t-bug The issue is related to an aspect of the software which is incorrect
Milestone

Comments

@huss
Copy link
Member

huss commented Feb 3, 2025

Describe the bug

Graphic pages are redrawing multiple times for unknown reasons. On most pages this is a performance issue. In the case of the recent line compare graphic in PR #1351 it leads to warning messages being displayed multiple times.

To Reproduce

Steps to reproduce the behavior:

  1. Select a meter (such as Sin Amp 1 kWh).
  2. Select a date range.
  3. Go to the compare line graphic.
  4. Select a shift (such as 1 week).
  5. It is likely that messages appear on the right and they are duplicated multiple times.

Note this can also be seen by using the debugger or console.log messages on this and other graphic pages.

Expected behavior

State does not seem to be changing in a way that ought to cause the redraws. The page should only render once if all the data is in Redux state.

Additional context

The profiler was used. It shows that the renders are clearly happening. Unfortunately, the hook number does not correspond to one it labels. It is suspected that it is from one automatically generated by React and most likely the Redux Toolkit. There is an open issue with the profiler on this and a future version may show which hook is involved.

@huss huss added p-high-priority This issue should be the focus of design and developement effort. t-bug The issue is related to an aspect of the software which is incorrect labels Feb 3, 2025
@huss huss added this to the 2.0 release milestone Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-high-priority This issue should be the focus of design and developement effort. t-bug The issue is related to an aspect of the software which is incorrect
Projects
None yet
Development

No branches or pull requests

1 participant