Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saleforce remove flatten from lodash #1067

Open
mtuchi opened this issue Mar 19, 2025 · 2 comments
Open

saleforce remove flatten from lodash #1067

mtuchi opened this issue Mar 19, 2025 · 2 comments

Comments

@mtuchi
Copy link
Collaborator

mtuchi commented Mar 19, 2025

Description
The salesforce adaptor uses flatten from lodash. See L103 in execute() function , We should remove this since it's an old implementation or add our own implementation of flatten in util

Eg:

function flatten(array) {
  return [].concat(...array);
  // or using flat()
  // return array.flat(1);
}
@github-project-automation github-project-automation bot moved this to New Issues in v2 Mar 19, 2025
@aleksa-krolls
Copy link
Member

@mtuchi is this spec ready to go? And should this be considered for the next sprint and moved to Sprint Candidates?

Or are you just adding it to the epic to consider for later? cc @martalovescoffee

@josephjclark
Copy link
Collaborator

Just adding to consider. I'll take a quick look to make sure this is the right thing to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New Issues
Development

No branches or pull requests

3 participants