Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up dev dependencies #1068

Open
josephjclark opened this issue Mar 19, 2025 · 2 comments
Open

Clean up dev dependencies #1068

josephjclark opened this issue Mar 19, 2025 · 2 comments
Assignees
@josephjclark
Labels
bug Something isn't working

Comments

@josephjclark
Copy link
Collaborator

The dev dependencies of most adaptors - like mocho and esno - should be declared a the top of the monorepo and not in the adaptor itself.

They just cause confusion and conflict in new adaptors
@josephjclark josephjclark added bug Something isn't working Needs Priority This issue needs to be prioritised labels Mar 19, 2025
@josephjclark josephjclark self-assigned this Mar 19, 2025
@github-project-automation github-project-automation bot moved this to New Issues in v2 Mar 19, 2025
@josephjclark josephjclark removed the Needs Priority This issue needs to be prioritised label Mar 19, 2025
@josephjclark
Copy link
Collaborator Author

mocha is actually on the root and shouldn't be declared inside specific adaptors (or the template)

@josephjclark
Copy link
Collaborator Author

When removing esno from a package, the build script starts failing. it shouldn't. Also the build script has a weirdly low esno version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josephjclark josephjclark

Labels
bug Something isn't working
Projects
Adaptor Development
Status: No status
v2
Status: New Issues
Milestone
No milestone
Development

No branches or pull requests
1 participant
@josephjclark