You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
In jsforce v3, connection.request() takes are two request arguments. HttpRequest and HttpRequestOptions. In #1070 we only support HttpRequest option. We should also add support for HttpRequestOptions and expose these options in http.request(path, request, options)
The text was updated successfully, but these errors were encountered:
I'm not really so sure. We should expose the same sorts of options like http does, like timeout. But for most of these options I think we should just provide sensible defaults.
The fact that we use connection.requesdt under-the-hood is a detail. We shouldn't expose it directly to users.
If users want to use the connection directly, we should explore sharing the client as a separate issue. For google sheets we've explored passing the sheets client straight to fn(), like this:
fn((state, sheets) =>{
// .. do stuff with sheets
});
This would be strictly for advanced users only. In the case of sheets, we think the client object leaks credentials so we're not really comfortable doing it.
Description
In jsforce v3,
connection.request()
takes are two request arguments. HttpRequest and HttpRequestOptions. In #1070 we only supportHttpRequest
option. We should also add support forHttpRequestOptions
and expose these options inhttp.request(path, request, options)
The text was updated successfully, but these errors were encountered: