-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Primero: add generic http helpers #1087
Comments
@redietr is about to finilise specing on Monday. Ping @hunterachieng when it's done. |
Please review the estimate after @redietr has finilised spec. |
to add credentials first @redietr , @hunterachieng can proceed afterwards |
@hunterachieng It is ready, you can proceed |
@redietr Looking at the adaptor, I see we already have a few functions in the adaptors.js file. I will proceed to create the generic functions in a separate http file. |
@aleksa-krolls |
Turns out we have problems with Primero. From #96
I've just spoken to Hunter and recommended that we add a clean new HTTP implementation, based on common/undici, in the If there's nothing super pressing, maybe next spring we can then refactor the rest of Primero and close out #96. Fix unit tests, remove callbacks, light tidy of the APIs, docs updates, the works. The aim would be stable, rather than beautiful |
Request
Add support for basic http helpers for these methods:
Credentials
Sample Code
If you like, you can include an example of what job code using your adaptor
might look like
Resources
Primero Doc
Logo Links
Logo already present
The text was updated successfully, but these errors were encountered: