Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Star generator refactor #131

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

[WIP] Star generator refactor #131

wants to merge 9 commits into from
+259 −295

Conversation

atravitz
Copy link
Contributor

@atravitz atravitz commented Mar 11, 2025 •
edited
Loading

addresses #130

depends on #129

PR Author Checklist

  • add news item if changes are user-facing
  • run pre-commit.ci autofix when the PR is ready for review

Tips

  • Comment "pre-commit.ci autofix" to have pre-commit.ci auto-format your PR.
    Since this will create a commit, it is best to make this comment when you are finished with your work.

Developers certificate of origin

Reviewer Checklist

  • news entry has been added if necessary
  • pre-commit auto fix has been run
  • any API breaks have been documented

Sorry, something went wrong.

@atravitz atravitz linked an issue Mar 11, 2025 that may be closed by this pull request
refactor star/radial network generator to use shared functions #130
Open
@atravitz atravitz changed the title Star generator refactor [WIP] Star generator refactor Mar 11, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.34884% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (0841aae) to head (4ac68cd).

Files with missing lines Patch % Lines
src/konnektor/network_planners/_map_scoring.py 93.93% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   87.93%   88.40%   +0.46%     
==========================================
  Files          49       49              
  Lines        1542     1457      -85     
==========================================
- Hits         1356     1288      -68     
+ Misses        186      169      -17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor star/radial network generator to use shared functions
1 participant
@atravitz