thread safety? #61

Author: OpenFunscripter

OFS-lib/OFS_FileLogging.cpp

@@ -12,6 +12,8 @@
 #include "stb_sprintf.h"
 #include <vector>
 
+#include <atomic>
+
 static OFS::AppLog OFS_MainLog;
 
 SDL_RWops* OFS_FileLogger::LogFileHandle = nullptr;
@@ -21,8 +23,8 @@ struct OFS_LogThread {
     SDL_cond* WaitFlush = nullptr;
     std::vector<char> LogMsgBuffer;
 
-    volatile bool ShouldExit = false;
-    volatile bool Exited = false;
+    std::atomic<bool> ShouldExit = false;
+    std::atomic<bool> Exited = false;
 
     void Init() noexcept
     {

src/api/OFS_WebsocketApi.h

@@ -4,6 +4,7 @@
 #include <vector>
 #include <memory>
 #include <vector>
+#include <atomic>
 
 #include "SDL_thread.h"
 #include "SDL_atomic.h"
@@ -14,8 +15,9 @@
 struct EventSerializationContext
 {
     SDL_cond* processCond = nullptr;
-    volatile bool shouldExit = false;
-    volatile bool hasExited = false;
+    
+    std::atomic<bool> shouldExit = false;
+    std::atomic<bool> hasExited = false;
 
     SDL_SpinLock eventLock = {0};
     std::vector<EventPointer> events;