Skip to content

Commit 61a80e8

Browse files
authored
Fix RSS item links (OSMCha#677)
1 parent 6c6c36c commit 61a80e8

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

osmchadjango/supervise/tests/test_views.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import xml.etree.ElementTree as ET
44

55
from django.urls import reverse
6+
from django.conf import settings
67
from django.contrib.gis.geos import MultiPolygon, Polygon, Point, LineString, GEOSGeometry
78

89
from rest_framework.test import APITestCase
@@ -864,7 +865,11 @@ def test_aoi_changesets_feed_view(self):
864865
items = [i for i in rss_data if i.tag == 'item']
865866
link = [i for i in items[0] if i.tag == 'link'][0]
866867
self.assertIn(
867-
"https://osmcha.org?aoi=",
868+
"{}/changesets/".format(settings.OSMCHA_URL),
869+
link.text
870+
)
871+
self.assertIn(
872+
"/?aoi=",
868873
link.text
869874
)
870875
self.assertEqual(

osmchadjango/supervise/views.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ def item_geometry(self, item):
140140
return item.bbox
141141

142142
def item_link(self, item):
143-
return "{}{}".format(settings.OSMCHA_URL, "?aoi={}".format(self.feed_id))
143+
return "{}/changesets/{}/?aoi={}".format(settings.OSMCHA_URL, item.id, self.feed_id)
144144

145145
def item_pubdate(self, item):
146146
return item.date

0 commit comments

Comments
 (0)