Skip to content

Commit 96aa95e

Browse files
authored
Merge pull request #1892 from peternewman/master-resync
Master resync
2 parents 5fa67e5 + d99729d commit 96aa95e

File tree

5 files changed

+63
-61
lines changed

5 files changed

+63
-61
lines changed

.github/workflows/build.yaml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
pkg: "gcc g++"
2222
- id: "distcheck-debian-stable-amd64-gcc"
2323
task: "distcheck"
24-
configure-args: "--enable-ja-rule --enable-e133 --enable-rdm-tests --enable-java-libs"
24+
configure-args: "--enable-ja-rule --enable-e133 --enable-rdm-tests"
2525
# TODO(Perry): Fix Debian 12 OOM issue on GitHub Actions
2626
container: "debian:stable"
2727
compiler:
@@ -30,7 +30,7 @@ jobs:
3030
pkg: "gcc g++"
3131
- id: "distcheck-debian-stable-amd64-clang"
3232
task: "distcheck"
33-
configure-args: "--enable-ja-rule --enable-e133 --enable-rdm-tests --enable-java-libs"
33+
configure-args: "--enable-ja-rule --enable-e133 --enable-rdm-tests"
3434
# TODO(Perry): Fix Debian 12 OOM issue on GitHub Actions
3535
container: "debian:stable"
3636
compiler:
@@ -90,17 +90,18 @@ jobs:
9090
- name: Autoreconf
9191
run: sudo --preserve-env -u builduser env "PATH=$PATH" autoreconf -i
9292
- name: Set configure arguments
93+
# Env var name DISTCHECK_CONFIGURE_FLAGS must be used, see #1881 and #1883
9394
run: |
94-
echo "GH_OLA_CONFIGURE_ARGS=${{ matrix.configure-args }}" >> $GITHUB_ENV
95+
echo "DISTCHECK_CONFIGURE_FLAGS=${{ matrix.configure-args }}" >> $GITHUB_ENV
9596
- name: Set additional Linux configure arguments
9697
if: runner.os == 'Linux'
9798
# Silence all deprecated declarations on Linux due to auto_ptr making the build log too long
9899
run: |
99-
echo "GH_OLA_CONFIGURE_ARGS=$GH_OLA_CONFIGURE_ARGS CPPFLAGS=-Wno-deprecated-declarations" >> $GITHUB_ENV
100+
echo "DISTCHECK_CONFIGURE_FLAGS=$DISTCHECK_CONFIGURE_FLAGS CPPFLAGS=-Wno-deprecated-declarations" >> $GITHUB_ENV
100101
- name: Print configure command
101-
run: echo "./configure $GH_OLA_CONFIGURE_ARGS"
102+
run: echo "./configure $DISTCHECK_CONFIGURE_FLAGS"
102103
- name: Configure
103-
run: sudo --preserve-env -u builduser env "PATH=$PATH" ./configure $GH_OLA_CONFIGURE_ARGS
104+
run: sudo --preserve-env -u builduser env "PATH=$PATH" ./configure $DISTCHECK_CONFIGURE_FLAGS
104105
- name: ${{ matrix.task }}
105106
run: sudo --preserve-env -u builduser env "PATH=$PATH" make ${{ matrix.task }} -j${{ steps.num-cpu-cores.outputs.NUM_CPU_CORES }} VERBOSE=1
106107
- name: Display structure of the built files

.travis-ci.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -291,6 +291,7 @@ elif [[ $TASK = 'pychecker-wip' ]]; then
291291
pychecker --quiet --limit 500 --blacklist $PYCHECKER_BLACKLIST $(find ./ -name "*.py" -and ! \( -name "*_pb2.py" -or -name "OlaClient.py" -or -name "ola_candidate_ports.py" \) | xargs)
292292
else
293293
# Otherwise compile and check as normal
294+
# Env var name DISTCHECK_CONFIGURE_FLAGS must be used, see #1881 and #1883
294295
if [[ "$TRAVIS_OS_NAME" = "linux" ]]; then
295296
# Silence all deprecated declarations on Linux due to auto_ptr making the build log too long
296297
export DISTCHECK_CONFIGURE_FLAGS='--enable-rdm-tests --enable-java-libs --enable-ja-rule --enable-e133 CPPFLAGS=-Wno-deprecated-declarations'

README.developer

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ The release lifecycle is:
5555
- New feature work occurs on the master branch.
5656
- Once the new features are considered stable or enough time has passed, a new
5757
minor release branch will be created, e.g. 0.10.
58-
- The minor release branch will be stablized with bugfixes, these bug fixes
58+
- The minor release branch will be stabilized with bugfixes, these bug fixes
5959
will also be merged back into master.
6060
- Once declared stable, a new patch branch 0 will be created e.g. 0.10.0
6161
- Release specific changes like the version number, debian files etc. will be

0 commit comments

Comments
 (0)