Exception noise from OAuth and REST (API2 )

[kiatng]

I have a project with OAuth REST which is interfacing with a mobile app. The exception.log is filling up with millions of lines due to unnecessary logs:

Mage_Api2_Exception: oauth_problem=token_rejected in .../app/code/core/Mage/Api2/Model/Auth/Adapter/Oauth.php:49
Mage_Api2_Exception: Missing required params in .../app/code/core/Mage/Api2/Model/Resource.php:629
Mage_Oauth_Exception in .../app/Mage.php:648, .../app/code/core/Mage/Oauth/Model/Server.php(421)

Each exception has 11 lines or more.

Preconditions (*)

Any version.

Steps to reproduce (*)

May be by unit tests?

Expected result (*)

1. Do not Mage::logException($e) for Mage_Api2_Exception and Mage_Oauth_Exception?
2. Only log one line per exception?

Actual result (*)

Noise in exception.log making it hard to detect the signal, problems that require attention.

[sreichel]

Mage_Api2_Exception: Missing required params in .../app/code/core/Mage/Api2/Model/Resource.php:629

Please post that lines. Looks like modified code. (?)

[kiatng]

Please post that lines. Looks like modified code. (?)

The project has lots of custom API2. When the client requests certain info but fail some validations, an exception is thrown, an example of bad request:

$this->_critical('Missing nationality', Mage_Api2_Model_Server::HTTP_BAD_REQUEST);

magento-lts/app/code/core/Mage/Api2/Model/Resource.php

Lines 613 to 626 in 00de7b5

	protected function _critical($message, $code = null)
	{
	if ($code === null) {
	$errors = $this->_getCriticalErrors();
	if (!isset($errors[$message])) {
	throw new Exception(
	sprintf('Invalid error "%s" or error code missed.', $message),
	Mage_Api2_Model_Server::HTTP_INTERNAL_ERROR,
	);
	}
	$code = $errors[$message];
	}
	throw new Mage_Api2_Exception($message, $code);
	}

Line 629 is throw new Mage_Api2_Exception($message, $code); in my project.

[sreichel]

Line 629 is throw new Mage_Api2_Exception($message, $code); in my project.

In core thats line 625 ...

Isnt it correct to log "$this->_critical('Missing nationality'"?

[kiatng]

Sure, it is OK to log, but it's unnecessary to include the trace in the log.