Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy feature in the view order page #4620

Open
addison74 opened this issue Feb 8, 2025 · 2 comments
Open

Copy feature in the view order page #4620

addison74 opened this issue Feb 8, 2025 · 2 comments

Comments

@addison74
Copy link
Contributor

This is a visual issue. Please visit Backend > Sales > Order then view any order from the grid. Resize the window as much as possible to see the effect.

Image

  1. The copy order number icon is no longer at the end of the text, but has moved to a new line.

  2. The email address cover icon is not in the correct position in the layout. It should be a little lower and to the right.

The icon correct size should be determined first (12px ?) then positioned accordingly. The bottom edge of the icon should be on the baseline of the text. There should also be some spacing from the text to create good visibility (4 px?)

@addison74 addison74 added the bug label Feb 8, 2025
@sreichel
Copy link
Contributor

sreichel commented Feb 8, 2025

The icon correct size should be determined first (12px ?) then positioned accordingly. The bottom edge of the icon should be on the baseline of the text. There should also be some spacing from the text to create good visibility (4 px?)

Nice. If you already have a solution, please add a PR.

@justinbeaty
Copy link
Contributor

The part (the order confirmation email was sent) being in the title is cumbersome. Could it be better to move it into the field table? Something like:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants