Add support for .env file
#5130
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # composer.json # composer.lock
# Conflicts: # composer.lock
github-actions
bot
added
Component: Core
Copilot finished reviewing on behalf of
sreichel
December 4, 2025 17:14
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for .env files to OpenMage using the vlucas/phpdotenv library, enabling developers to configure environment variables through a .env file rather than relying solely on system environment variables.
Key changes:
- Adds
vlucas/phpdotenvv5.6 dependency along with its dependencies (graham-campbell/result-typeandphpoption/phpoption) - Initializes dotenv in
app/Mage.phpto load.envfile from the application root - Changes
EnvironmentConfigLoaderto read from$_ENVinstead ofgetenv()to access variables loaded by phpdotenv - Adds
.envto.gitignoreto prevent committing sensitive configuration
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Adds vlucas/phpdotenv ^5.6 dependency |
| composer.lock | Locks new dependencies: phpdotenv v5.6.2, phpoption 1.9.4, and graham-campbell/result-type v1.1.3 |
| app/Mage.php | Initializes dotenv loader with integer validation for MAGE_IS_DEVELOPER_MODE and OPENMAGE_CONFIG_OVERRIDE_ALLOWED |
| app/code/core/Mage/Core/Helper/EnvironmentConfigLoader.php | Changes environment variable source from getenv() to $_ENV to read phpdotenv-loaded variables |
| .gitignore | Adds .env file to prevent committing sensitive configuration |
Co-authored-by: Copilot <[email protected]>
|
addison74
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Adding missing piece to ENV config loader with adding support for
.envfiles.