Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

Optimize the Authentication Exception in ClientService.java #1695

Closed
prb112 opened this issue Jul 2, 2015 · 1 comment
Closed

Optimize the Authentication Exception in ClientService.java #1695

prb112 opened this issue Jul 2, 2015 · 1 comment
Assignees

Comments

@prb112
Copy link
Contributor

prb112 commented Jul 2, 2015

When using the BasicEndpoint with an invalid password, the user receives a ClientServiceException.
ClientService Exception on Line 1317.
1 - The Response Code on 1316 should be checked to see if it's 401 before forceAuthentication
(Else it's possible you get an error)
2 - Throw an AuthenticationException specific to the ClientServices and not wrapped in a generic ClientServicesException.

  • or -
    3 - Add a message to the AuthenticationException that indicates the issue
@prb112
Copy link
Contributor Author

prb112 commented Jul 29, 2015

Rajmeet completed this pull request

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants