Expose Timeline's find_clips
#66
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Mahony <[email protected]>
Signed-off-by: Mike Mahony <[email protected]>
mikemahony
force-pushed
the
expose_timeline_find_clips
branch
from
e406a47 to
724191a
Compare
vade
reviewed
May 12, 2025
| } | ||
|
|
||
| NSArray* timeline_find_clips(CxxRetainer* self, CxxErrorStruct* cxxErr) { | ||
| auto array = [NSMutableArray new]; |
Collaborator
There was a problem hiding this comment.
Thanks for this PR!
I have a naive q - apologies if this is obvious! WRT to memory management, is there a possible leak with the Clips returned from SO_cast<otio::Timeline>(self)->find_clips(&aeh.error_status)) via NSValue?
Are the Clip objects life time managed by the SO_cast correctly via NSValue when vended to Swift in the findClips()?
I see the pointer values survive through to swift, via result.append(SerializableObject.findOrCreate(cxxPtr: cxxPtr) as! Clip) - are they cleaned up by the dynamic cast within the SO_cast?
| var result = [Clip]() | ||
| for child in children_array { | ||
| if let nsptr = child as? NSValue, let cxxPtr = nsptr.pointerValue { | ||
| result.append(SerializableObject.findOrCreate(cxxPtr: cxxPtr) as! Clip) |
Collaborator
There was a problem hiding this comment.
May I suggest a
if let clip = SerializableObject.findOrCreate(cxxPtr: cxxPtr) as? Clip to avoid a exception / crash on a bad cast?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65
Exposes the
Timeline'sfind_clipsmethod. This pass exposes the method without the optionalsearch_rangeandshallow_searchparameters - a future PR could expose those params.Request includes a new test
testTimelineClipAvailableBoundsand refactors the existing two tests in the suite to keep the code D.R.Y. The otio file used in the new test came from the OpenTimelineIO test sample data here.