Remove unnecessary default constructors

This patch removes explicitly written `= default` constructors
for several structs and classes that don't require it, because
the compiler will do the same thing automatically.

Signed-off-by: Razvan Cojocaru <[email protected]>

Author: rzvncj

openvpn/addr/pool.hpp

@@ -29,8 +29,6 @@ template <typename ADDR>
 class PoolType
 {
   public:
-    PoolType() = default;
-
     /**
      * @brief Adds range of addresses to pool (pool will own the addresses).
      * @param range RangeType of IP Addresses

openvpn/applecrypto/util/rand.hpp

@@ -28,8 +28,6 @@ class AppleRandom : public StrongRandomAPI
 
     typedef RCPtr<AppleRandom> Ptr;
 
-    AppleRandom() = default;
-
     std::string name() const override
     {
         return "AppleRandom";

openvpn/client/clicreds.hpp

@@ -32,8 +32,6 @@ class ClientCreds : public RC<thread_unsafe_refcount>
   public:
     typedef RCPtr<ClientCreds> Ptr;
 
-    ClientCreds() = default;
-
     void set_username(const std::string &username_arg)
     {
         username = username_arg;

openvpn/common/options.hpp

@@ -533,8 +533,6 @@ class OptionList : public std::vector<Option>, public RCCopyable<thread_unsafe_r
     class LexComment : public LexQuoteMixin
     {
       public:
-        LexComment() = default;
-
         void put(char c)
         {
             if (in_comment)

openvpn/crypto/cryptodc.hpp

@@ -100,8 +100,6 @@ class CryptoDCSettingsData
   public:
     OPENVPN_SIMPLE_EXCEPTION(no_data_channel_factory);
 
-    CryptoDCSettingsData() = default;
-
     void set_cipher(CryptoAlgs::Type cipher)
     {
         cipher_ = cipher;
@@ -195,8 +193,6 @@ class CryptoDCSettings : public CryptoDCSettingsData
   public:
     OPENVPN_SIMPLE_EXCEPTION(no_data_channel_factory);
 
-    CryptoDCSettings() = default;
-
     void set_factory(const CryptoDCFactory::Ptr &factory)
     {
         factory_ = factory;

openvpn/crypto/packet_id_control.hpp

@@ -180,9 +180,6 @@ class PacketIDControlReceiveType
 
     OPENVPN_SIMPLE_EXCEPTION(packet_id_not_initialized);
 
-    // TODO: [OVPN3-933] Consider RAII'ifying this code
-    PacketIDControlReceiveType() = default;
-
     void init(const char *name_arg,
               const int unit_arg,
               const SessionStats::Ptr &stats_arg)

openvpn/openssl/util/rand.hpp

@@ -29,8 +29,6 @@ class OpenSSLRandom : public StrongRandomAPI
 
     typedef RCPtr<OpenSSLRandom> Ptr;
 
-    OpenSSLRandom() = default;
-
     std::string name() const override
     {
         return "OpenSSLRandom";

openvpn/transport/dco.hpp

@@ -53,8 +53,6 @@ struct DCO : public virtual RC<thread_unsafe_refcount>
 
     struct TunConfig
     {
-        TunConfig() = default;
-
 #if defined(OPENVPN_PLATFORM_WIN)
         TunWin::SetupFactory::Ptr setup_factory;