Fix AragonRegistrar

Author: facuspagnuolo

package_manager/contracts/PR/aragon/AragonRegistrar.sol

@@ -1,5 +1,4 @@
-pragma solidity ^0.4.18;
-
+pragma solidity 0.4.24;
 
 import '../Registrar.sol';
 import '@aragon/os/contracts/apps/AragonApp.sol';
@@ -14,35 +13,35 @@ import '@aragon/os/contracts/factory/ENSFactory.sol';
 import '@aragon/os/contracts/factory/APMRegistryFactory.sol';
 
 contract AragonRegistrar is AragonApp, Registrar {
-  // bytes32 constant public CREATE_NAME_ROLE = keccak256("CREATE_NAME_ROLE");
-  // bytes32 constant public DELETE_NAME_ROLE = keccak256("DELETE_NAME_ROLE");
-  // bytes32 constant public POINT_ROOTNODE_ROLE = keccak256("POINT_ROOTNODE_ROLE");
-  bytes32 constant public CREATE_NAME_ROLE = 0xf86bc2abe0919ab91ef714b2bec7c148d94f61fdb069b91a6cfe9ecdee1799ba;
-  bytes32 constant public DELETE_NAME_ROLE = 0x03d74c8724218ad4a99859bcb2d846d39999449fd18013dd8d69096627e68622;
-  bytes32 constant public POINT_ROOTNODE_ROLE = 0x9ecd0e7bddb2e241c41b595a436c4ea4fd33c9fa0caa8056acf084fc3aa3bfbe;
-
-  function ens() public view returns(AbstractENS) {
-    return AbstractENS(registry);
-  }
+  // bytes32 public constant CREATE_NAME_ROLE = keccak256("CREATE_NAME_ROLE");
+  // bytes32 public constant DELETE_NAME_ROLE = keccak256("DELETE_NAME_ROLE");
+  // bytes32 public constant POINT_ROOTNODE_ROLE = keccak256("POINT_ROOTNODE_ROLE");
+  bytes32 public constant CREATE_NAME_ROLE = 0xf86bc2abe0919ab91ef714b2bec7c148d94f61fdb069b91a6cfe9ecdee1799ba;
+  bytes32 public constant DELETE_NAME_ROLE = 0x03d74c8724218ad4a99859bcb2d846d39999449fd18013dd8d69096627e68622;
+  bytes32 public constant POINT_ROOTNODE_ROLE = 0x9ecd0e7bddb2e241c41b595a436c4ea4fd33c9fa0caa8056acf084fc3aa3bfbe;
 
   function initialize(ERC137Registry _registry, bytes32 _rootNode) public onlyInit {
     initialized();
     Registrar.initialize(_registry, _rootNode);
   }
 
+  function ens() public view returns(ERC137Registry) {
+    return registry;
+  }
+
   function createName(bytes32 _label, address _owner) public auth(CREATE_NAME_ROLE) returns (bytes32) {
-    super.createName(_label, _owner);
+    return super.createName(_label, _owner);
   }
 
   function createNameAndPoint(bytes32 _label, address _target) public auth(CREATE_NAME_ROLE) returns (bytes32) {
-    super.createNameAndPoint(_label, _target);
+    return super.createNameAndPoint(_label, _target);
   }
 
   function pointRootNode(address _target) public auth(POINT_ROOTNODE_ROLE) {
     super.pointRootNode(_target);
   }
 
-  function deleteName(bytes32 _label) public auth(DELETE_NAME_ROLE)  {
+  function deleteName(bytes32 _label) public auth(DELETE_NAME_ROLE) {
     super.deleteName(_label);
   }
 }

package_manager/contracts/PR/zeppelin/ZeppelinRegistrar.sol

@@ -12,11 +12,11 @@ contract ZeppelinRegistrar is Ownable, Registrar {
   }
 
   function createName(bytes32 _label, address _owner) public onlyOwner returns (bytes32) {
-    super.createName(_label, _owner);
+    return super.createName(_label, _owner);
   }
 
   function createNameAndPoint(bytes32 _label, address _target) public onlyOwner returns (bytes32) {
-    super.createNameAndPoint(_label, _target);
+    return super.createNameAndPoint(_label, _target);
   }
 
   function pointRootNode(address _target) public onlyOwner {

package_manager/test/contracts/PR/aragon/AragonRegistrar.test.js

@@ -2,12 +2,11 @@ import { hash as namehash } from 'eth-ens-namehash'
 import assertRevert from '../../../helpers/assertRevert'
 
 const keccak256 = require('js-sha3').keccak_256
+
 const AragonRegistrar = artifacts.require('AragonRegistrar')
-// const AragonRegistrar = artifacts.require('ENSSubdomainRegistrar')
 
 const ENS = artifacts.require('ENS')
 const ENSFactory = artifacts.require('ENSFactory')
-const PublicResolver = artifacts.require('PublicResolver')
 const Kernel = artifacts.require('Kernel')
 const ACL = artifacts.require('ACL')
 const APMRegistry = artifacts.require('APMRegistry')