Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Component] Create component - Link #400

Closed
Tracked by #545
ludovic35 opened this issue Jan 21, 2025 · 8 comments · Fixed by #401
Closed
Tracked by #545

[Component] Create component - Link #400

ludovic35 opened this issue Jan 21, 2025 · 8 comments · Fixed by #401
Assignees
@B3nz01d @pya35 @MaximeTonnerre
Labels
⚛️ component Related to a component provided by the library 📱 demo app Update of the Demo App 📖 documentation Improvements or additions to documentation 🧰 library 👌 OK Accessibility A11Y review has been done 👌 OK Design Design review has been done 👌 OK PO Product Owner review has been done

Comments

@ludovic35
Copy link
Member

ludovic35 commented Jan 21, 2025 •
edited
Loading

Description

As a user of the Ouds library
I want to be able to use the component
So that I can add an Ouds component in my own projects

As a user of the library
I want to be able to use the component
So that I have access to the documentation on how to use it

As a user of the Demo App
I want to access the Component
So that I can understand how to use it:

  • while using the demo app I can interact with the available options and observe the changes on the component itself
  • I can see the code associated to the component customization
  • I can copy and paste the code from the app based on the selected customization
  • or when looking into the code of the app itself, I would also understand how to use it

Context

The component is described in the Design tools and allows to describe the various states and variants.

Variants

TBD

Demo App

TBD
@ludovic35 ludovic35 added 📖 documentation Improvements or additions to documentation ⚛️ component Related to a component provided by the library 📱 demo app Update of the Demo App 🧰 library labels Jan 21, 2025
@ludovic35 ludovic35 moved this from Todo to In Progress in ⚛️ [OUDS] Project Jan 21, 2025
@pylapp pylapp changed the title Create component - Link [Component] Create component - Link Jan 22, 2025
@ludovic35 ludovic35 linked a pull request Jan 23, 2025 that will close this issue
[#400] Create Link component #401
Merged
16 tasks
@pylapp
Copy link
Member

pylapp commented Jan 23, 2025

📣 New TestFlight ALPHA upload available 🚀

Please, get the new build from TestFlight app, or contact the project maintainers (@ludovic35 or @pylapp) to get access.

  • Display name: Design System Toolbox ALPHA (400)
  • Version: 0.10.0
  • Build number: 1737636437
  • Build tag: 70a7fd9
  • Build type: ALPHA
  • Build details (GitHub): 400

cc @B3nz01d (product owner)
cc @pylapp @ludovic35 (dev team)
cc @MaximeTonnerre @mccart77 @iassab @TonyAntonyHello (design team)

This is an automated message sent with love thanks to Fastlane from our CI/CD pipeline 🤘

@pylapp
Copy link
Member

pylapp commented Jan 23, 2025

📣 New TestFlight ALPHA upload available 🚀

Please, get the new build from TestFlight app, or contact the project maintainers (@ludovic35 or @pylapp) to get access.

  • Display name: Design System Toolbox ALPHA (400)
  • Version: 0.10.0
  • Build number: 1737644803
  • Build tag: c5c19e2
  • Build type: ALPHA
  • Build details (GitHub): 400

cc @B3nz01d (product owner)
cc @pylapp @ludovic35 (dev team)
cc @MaximeTonnerre @mccart77 @iassab @TonyAntonyHello (design team)

This is an automated message sent with love thanks to Fastlane from our CI/CD pipeline 🤘

@B3nz01d B3nz01d added the 👌 OK PO Product Owner review has been done label Jan 23, 2025
@pylapp
Copy link
Member

pylapp commented Jan 24, 2025

📣 New TestFlight ALPHA upload available 🚀

Please, get the new build from TestFlight app, or contact the project maintainers (@ludovic35 or @pylapp) to get access.

  • Display name: Design System Toolbox ALPHA (400)
  • Version: 0.10.0
  • Build number: 1737734875
  • Build tag: f83a22a
  • Build type: ALPHA
  • Build details (GitHub): 400

cc @B3nz01d (product owner)
cc @pylapp @ludovic35 (dev team)
cc @MaximeTonnerre @mccart77 @iassab @TonyAntonyHello (design team)

This is an automated message sent with love thanks to Fastlane from our CI/CD pipeline 🤘

@pylapp
Copy link
Member

pylapp commented Jan 27, 2025

📣 New TestFlight ALPHA upload available 🚀

Please, get the new build from TestFlight app, or contact the project maintainers (@ludovic35 or @pylapp) to get access.

  • Display name: Design System Toolbox ALPHA (400)
  • Version: 0.10.0
  • Build number: 1737966409
  • Build tag: 2e63071
  • Build type: ALPHA
  • Build details (GitHub): 400

cc @B3nz01d (product owner)
cc @pylapp @ludovic35 (dev team)
cc @MaximeTonnerre @mccart77 @iassab @TonyAntonyHello (design team)

This is an automated message sent with love thanks to Fastlane from our CI/CD pipeline 🤘

@ludovic35 ludovic35 added the 👌 OK Design Design review has been done label Jan 29, 2025
@ludovic35 ludovic35 moved this from In Progress to In Review in ⚛️ [OUDS] Project Jan 29, 2025
@pya35
Copy link
Member

pya35 commented Jan 30, 2025

  • Les liens sont dans des composants de type bouton ? pourquoi ne pas les déclarer comme des liens ?

  • en mode small, la zone tactile semble être inférieure à 44pt, la taille minimale recommandée par Apple est 44pt (WCAG niveau AAA) – pour un lien inline au sein d’une phrase ce n’est pas nécessaire, mais dans le cas d’un lien isolé il faudrait respecter la taille minimale si possible.

Image

  • En mode "icon+text", si le picto a vocation a être informatif alors il faut prévoir un accessibilityLabel

@pya35
Copy link
Member

pya35 commented Jan 30, 2025

Remarque sur le texte d'introduction :

Image

Dans la logique mobile, les liens internes sont plutôt identifiés comme des boutons.
Je dirais plutôt "Links direct (or redirect) users to external resources out of the application (website, document or another app)"

@ludovic35
Copy link
Member Author

Remarque sur le texte d'introduction :

Image

Dans la logique mobile, les liens internes sont plutôt identifiés comme des boutons. Je dirais plutôt "Links direct (or redirect) users to external resources out of the application (website, document or another app)"

@B3nz01d what do you think ?

@ludovic35
Copy link
Member Author

  • Les liens sont dans des composants de type bouton ? pourquoi ne pas les déclarer comme des liens ?
  • en mode small, la zone tactile semble être inférieure à 44pt, la taille minimale recommandée par Apple est 44pt (WCAG niveau AAA) – pour un lien inline au sein d’une phrase ce n’est pas nécessaire, mais dans le cas d’un lien isolé il faudrait respecter la taille minimale si possible.

Image

  • En mode "icon+text", si le picto a vocation a être informatif alors il faut prévoir un accessibilityLabel

Point1 et 2, corrigé.
Le point 3 l'icon est décoratif.

@pylapp pylapp mentioned this issue Jan 31, 2025
Merged
16 tasks
@pylapp pylapp added the 👌 OK Accessibility A11Y review has been done label Jan 31, 2025
@pylapp pylapp closed this as completed in 3db0aaa Jan 31, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in ⚛️ [OUDS] Project Jan 31, 2025
@pylapp pylapp mentioned this issue Feb 20, 2025
Merged
pylapp added a commit that referenced this issue Feb 20, 2025
@pylapp @ludovic35 @boosted-bot
Version 0.11.0 (#465)
39bbdbf 
Release of version 0.11.0
See below the full CHANGELOG details.

Added:
- [DesignToolbox] French support
- [Library] `ControlItem` component tokens (tokens library v0.6.0)
- [Tool] Upload the IPA of DesignToolbox to the publication store ([#451](#451))
- [Tool] Add with a script the token library version in documentation and Design Toolbox ([#425](#425))
- [DesignToolbox] Add text field in component configuration to customize text ([#436](#436))
- [Library] Link component ([#400](#400))

Changed:
- [Tool] Move from XCTest to Swift Testing framework ([#340](#340))
- [Tool] Add SwiftPolyglot in CI/CD to check missing localizables ([#454](#454))
- [Tool] Move legacy Localizable.strings file to new Apple strings catalogs ([#454](#454))
- [Tool] Change precision and perception of UI tests to make them pass on Apple Silicon SoC ([#305](#305))
- [DesignToolbox] Reorganise snapshots files for tests of tokens ([#432](#432))
- [Library] Apply new naming conventions ([#453](#453))
- [Library] `Badge`, `Breadcrumb`, `BulletList`, `Button`, `Checkbox`, `InputText`, `Link`, `Skeleton`, `Switch` component tokens (tokens library v0.6.0)

Co-authored-by: Pierre-Yves Lapersonne <[email protected]>
Co-authored-by: Ludovic Pinel <[email protected]>
Co-authored-by: boosted-bot <[email protected]>
@B3nz01d B3nz01d mentioned this issue Mar 21, 2025
Open
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@B3nz01d B3nz01d

@pya35 pya35

@MaximeTonnerre MaximeTonnerre

Labels
⚛️ component Related to a component provided by the library 📱 demo app Update of the Demo App 📖 documentation Improvements or additions to documentation 🧰 library 👌 OK Accessibility A11Y review has been done 👌 OK Design Design review has been done 👌 OK PO Product Owner review has been done
Projects
⚛️ [OUDS] Project
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#400] Create Link component Orange-OpenSource/ouds-ios
5 participants
@pylapp @ludovic35 @B3nz01d @pya35 @MaximeTonnerre