Skip to content

wallet.service.ts::sendPayment and app/api/wallet/send/route.ts never touch the Stellar network #63

Description

@ndii-dev

sendPayment POSTs to /api/wallet/send, which validates shape/regex and returns hash: \0x${Math.random().toString(16).slice(2, 66)}`withstatus: 'completed'— a fabricated success with a hex format that isn't even a valid Stellar transaction hash shape. The saveddb.saveTransactioncall persists this fake hash as if it were real. There's also no connection to the realOrbit-Wal/backend REST API (POST /api/v1/wallet/send`) that does perform real Horizon submission.

Definition of done:

  • Route delegates to real transaction building/signing/submission (either via backend API call or direct Horizon SDK)
  • status reflects actual ledger state (pending/completed/failed), not an assumed success
  • Persisted transaction record stores a real, verifiable Stellar tx hash format

Before opening a PR for this issue, read CONTRIBUTING.md.

This is not a starter-issue. The Definition of done above is the full
acceptance criteria, not a subset to sample from — a PR that addresses part
of it is an unfinished issue, not a smaller one. Your PR must include, in
the PR description itself:

  • Root cause / design-decision rationale in your own words — not a restatement of this issue
  • Every Definition of done bullet above addressed explicitly, with a one-line note on how
  • Evidence the code actually runs: pasted test/build output, a screen recording or before/after screenshots for UI changes, or real (non-mocked) logs for network/contract-facing work
  • New or updated tests included and shown passing (paste the output)
  • Any adjacent/related behavior this issue calls out re-verified, not assumed unaffected

PRs missing these will be sent back before review, not reviewed and rejected — please do this up front.

Metadata

Metadata

Assignees

Labels

GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardOfficial Campaign | FWC26Campaign: Official Campaign | FWC26

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions