For a wallet product, especially post the custody-model decision (see mock-db.ts issue above), non-custodial hardware-wallet signing is a common expectation. Nothing in lib/services or components references Ledger, WalletConnect, or any external signer interface — the entire codebase assumes either a mock or (once real) a server/browser-held key.
Definition of done:
- Signing abstraction that can target either an in-app key or an external signer (Ledger via @ledgerhq/hw-transport-webhid or similar) without changing the transaction-building code above it
- At minimum, Ledger XLM app integration for the send flow
Before opening a PR for this issue, read CONTRIBUTING.md.
This is not a starter-issue. The Definition of done above is the full
acceptance criteria, not a subset to sample from — a PR that addresses part
of it is an unfinished issue, not a smaller one. Your PR must include, in
the PR description itself:
PRs missing these will be sent back before review, not reviewed and rejected — please do this up front.
For a wallet product, especially post the custody-model decision (see mock-db.ts issue above), non-custodial hardware-wallet signing is a common expectation. Nothing in lib/services or components references Ledger, WalletConnect, or any external signer interface — the entire codebase assumes either a mock or (once real) a server/browser-held key.
Definition of done:
Before opening a PR for this issue, read CONTRIBUTING.md.
This is not a starter-issue. The Definition of done above is the full
acceptance criteria, not a subset to sample from — a PR that addresses part
of it is an unfinished issue, not a smaller one. Your PR must include, in
the PR description itself:
PRs missing these will be sent back before review, not reviewed and rejected — please do this up front.