-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable upload of experiment configs #406
Comments
We already have download experiment JSON (https://github.com/PAIR-code/deliberate-lab/blob/main/utils/src/data.ts#L25), so we just need an upload button! |
@cjqian instead of doing this, what do you think about replacing games with ExperimentTemplates? This is what is supposed to be used for experimenters uploading/updating their own experiment configs that can be reused. We initially had "games" because they had features that couldn't be edited in UI,* but once we fix that (which we will need to if we want experimenters to be able to config via UI anyway), we don't really need games. *We have a backlog of adding experiment editor UI support for chat threads, chip negotiation, and maybe some tiny things - so if we want this, we'll have to do those first. |
What’s the difference between “games” and “experiment templates”? |
Games are supposed to be a temporary workaround (hardcoded and configurable only by us. For example, the current negotiation game must be hardcoded and can't be edited via the UI because we didn't build the negotiation stage editor yet). "Experiment templates" are for experimenters to configure in the UI (notably, they are stored in firebase) and otherwise work like games (in that you select them and they are loaded into the editor for you to optionally edit + save. We already have backend support experiment templates (set up when the platform was set up), so it sounds like this is a good point to move over (and if we have no more hardcoded examples, then we can just get rid of games - which would also prevent them from being publicly visible in the repo). I'm going to move this bug into a new "Add experiment templates" milestone to help illustrate what's involved here (all of this would be blocking the ability for experimenters to edit current games anyway). Let me know what you think - we can always cancel the milestone and/or adjust scope? In the meantime, let's consider this bug scoped to "upload button that loads an experiment json correctly into the experiment editor." @dimits-ts fyi |
Great, thanks for the clarification! |
CUJs:
The text was updated successfully, but these errors were encountered: