use replaceAll from PDAL

hobu · hobu · commit f35cacfd12cf · 2025-09-03T08:30:31.000-05:00
diff --git a/src/pdal/test/Support.cpp b/src/pdal/test/Support.cpp
@@ -137,8 +137,8 @@ uint32_t Support::diff_text_files(std::istream& str1, std::istream& str2,
         std::getline(str2, buf2);
 
         // Remove \r's
-        buf1.erase( std::remove(buf1.begin(), buf1.end(), '\r'), buf1.end() );
-        buf2.erase( std::remove(buf2.begin(), buf2.end(), '\r'), buf2.end() );
+        pdal::Utils::replaceAll(buf1, "\r", "");
+        pdal::Utils::replaceAll(buf2, "\r", "");
 
         if (currLine == ignoreLine1)
         {

Original file line number	Diff line number	Diff line change
`@@ -137,8 +137,8 @@ uint32_t Support::diff_text_files(std::istream& str1, std::istream& str2,`
`137`	`137`	`std::getline(str2, buf2);`
`138`	`138`
`139`	`139`	`// Remove \r's`
`140`		`- buf1.erase( std::remove(buf1.begin(), buf1.end(), '\r'), buf1.end() );`
`141`		`- buf2.erase( std::remove(buf2.begin(), buf2.end(), '\r'), buf2.end() );`
	`140`	`+ pdal::Utils::replaceAll(buf1, "\r", "");`
	`141`	`+ pdal::Utils::replaceAll(buf2, "\r", "");`
`142`	`142`
`143`	`143`	`if (currLine == ignoreLine1)`
`144`	`144`	`{`