Merge pull request #165 from arcfieldOSS/final

Modify "mkdir()" to be multi-writer safe

Author: khoaofgod

phpfastcache/3.0.0/abstract.php

@@ -280,13 +280,9 @@ protected function readfile($file) {
                 throw new Exception("Can't Read File",96);
 
             }
-            if (flock($file_handle, LOCK_SH | LOCK_NB)) {
-                while (!feof($file_handle)) {
-                    $line = fgets($file_handle);
-                    $string .= $line;
-                }
-            } else {
-                throw new Exception("Can't Read File",96);
+            while (!feof($file_handle)) {
+                $line = fgets($file_handle);
+                $string .= $line;
             }
             fclose($file_handle);
 

phpfastcache/3.0.0/drivers/files.php

@@ -52,15 +52,13 @@ private function getFilePath($keyword, $skip = false) {
          * Skip Create Sub Folders;
          */
         if($skip == false) {
-            if(!@file_exists($path)) {
-                if(!@mkdir($path,$this->__setChmodAuto())) {
+            //if it doesn't exist, I can't create it, and nobody beat me to creating it:
+            if(!@is_dir($path) && !@mkdir($path,$this->__setChmodAuto()) && !@is_dir($path)) {
                     throw new Exception("PLEASE CHMOD ".$this->getPath()." - 0777 OR ANY WRITABLE PERMISSION!",92);
-                }
-
-            } elseif(!is_writeable($path)) {
-                if(!chmod($path,$this->__setChmodAuto())) {
+            }
+            //if it does exist (after someone beat me to it, perhaps), but isn't writable or fixable:
+            if(@is_dir($path) && !is_writeable($path) && !@chmod($path,$this->__setChmodAuto())) {
                     throw new Exception("PLEASE CHMOD ".$this->getPath()." - 0777 OR ANY WRITABLE PERMISSION!",92);
-                }
             }
         }