Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare more than five countries, compare multiple countries and multiple topics, get long timeperiods in smaller time resolution #413

Open
mjohli opened this issue May 22, 2022 · 3 comments

Comments

@mjohli
Copy link

mjohli commented May 22, 2022

Hi there,
thank you so much for the awesome package, it is really useful for me.
When working with it I came to the restriction (coming from google trends, not from your package) that one can only compare five countries at once, one has to decide if one wants to compare multiple countries or multiple topics, both at once is not possible, and that the longer the timeperiod looked at, the more coarse-grained the time resolution gets.
I started writing a function solving these issues and it seems to work. Are there any reasons (e.g., legal concerns, ...) that this could not be implemented? If yes, let me know, if no I'd be happy to contribute these functions and make a PR.

@JBleher
Copy link
Contributor

JBleher commented May 22, 2022

Dear mjohli, have a look at our paper. See https://doi.org/10.1016/j.ecosta.2021.10.006. One can get around the restrictions by downloading a comparison. Best regards, J

@mjohli
Copy link
Author

mjohli commented May 22, 2022

Dear J,
Thank you so much for pointing me to that paper. My approach is actually quite similar to yours but your paper showed me quite well how I could improve my function. My original question was rather why a ready-to-use function to get data beyond the restrictions (e.g., as the algorithm you describe in your paper) is not implemented in the gtrendsR package. Since I am currently writing these functions for a project, I thought it would be a good idea to provide them for others and I would be more than happy to contribute them to your awesome package.
Kind regards, mjohli

@JBleher
Copy link
Contributor

JBleher commented May 22, 2022

Dear mjohli, This is a great idea. I have already written these functions as referenced in the paper. Feel free to improve them... They are not part of gtrendsR though. See here. The problem in my opinion is: The number of queries becomes large quickly when you'd like to use smaller time intervals. Therefore, I do not think it is wise to add these functions to GTrends as standard functionality. In my opinion, users should need to figure out how to set the number of queries they submit during a given time interval in accordance to Google's rate limits (which are unknown to me and have changed over time). Giving users in a standard function the possibility to flood the GTrends website with queries, will result in users complaining about errors everytime Google changes the rate limits. It might also be a violation of Google's Terms of Service... I am not a lawyer, in the Terms of Use Google has the rule "don’t abuse, harm, interfere with, or disrupt the services — for example, by [...] bypassing our systems or protective measures [...]". Again, I am not a lawyer, rate limits, possibly, might be understood as such a system. So, I would recommend to handle the issue with care and within the boundaries of Google's Terms of Use...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants