Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vlp32c and column sincos #53

Closed
zlacelle opened this issue Nov 1, 2019 · 2 comments
Closed

vlp32c and column sincos #53

zlacelle opened this issue Nov 1, 2019 · 2 comments

Comments

@zlacelle
Copy link

zlacelle commented Nov 1, 2019

Hello,
I'm using a VLP-32C which has non-column data (each column actually has data at -4.2, -1.4, 1.4, and 4.2 degrees +/- the nominal column azimuth). Additionally, the data is not evenly spaced vertically either.

The vertical data is easy enough to fix (instead of evenly spacing sin/cos in the FillCosSin() based on some step, define the step per vertical row index). But for the column spacing, this is now dependent upon the row that it's in.

An example of where this is used is in the CreateAngleImage in DepthGroundRemover: the code uses the consines and sines vectors per row. I think it assumes even spacing on columns?

What do you think should be the approach for sensors like the VLP-32C, which does not have a column with an exactly same azimuth for every point? I think that #33 is incorrect, since it doesn't handle the uneven vertical spacing or the varying azimuths per column.

@niosus
Copy link
Member

niosus commented Nov 21, 2019

You can use the uneven spacing in the columns by using a sensor config. See how the configs are created. A span can be created from an arbitrary vector or you can use a file with your config.

As for the rows, I see no issue here. When projecting the points provided by the lidar (or reading the angles and range directly) you will just map those to different rows. The image would still be complete.

I have worked in a similar fashion with the sensor in question and have seen no issues with this.

@niosus
Copy link
Member

niosus commented Nov 21, 2019

I will close this now, but feel free to reopen if you still think there is an issue here.

@niosus niosus closed this as completed Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants