Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Adaptive Threshold #20

Open
tizianoGuadagnino opened this issue Nov 19, 2024 · 0 comments
Open

Investigate Adaptive Threshold #20

tizianoGuadagnino opened this issue Nov 19, 2024 · 0 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@tizianoGuadagnino
Copy link
Collaborator

tizianoGuadagnino commented Nov 19, 2024

Motivation

Our current implementation, based on the discussion in #15 is more consistent with using wheel odometry as an initial guess. However, many different implementations will work in this scenario; for example, @benemer proposes inferring from the map parameters as simple.

$\tau = 6 \cdot \frac{\text{voxel size}}{\sqrt{\text{max points in voxel}}}$

According to our evaluation, this gives identical results. This raises the question of how we can properly decide on a threshold value just based on data. Our main issue is a lack of proper data to test this, and we will need lots of data to make a final decision based on a bunch of different scenarios. @benemer and I want to come back to this, and anyone is welcome to this discussion in this issue or future PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants