final refactor and all attachment cases tested, SMTP good

Author: PandaWood

src/ExceptionReporter/Mail/MailSender.cs

@@ -73,11 +73,10 @@ private void SmtpClient_SendCompleted(object sender, System.ComponentModel.Async
 		public void SendMapi(string exceptionReport)
 		{
 			var mapi = new SimpleMapi();
-			var attacher = new AttachAdapter(mapi);
 
 			mapi.AddRecipient(_reportInfo.EmailReportAddress, null, false);
 
-			AttachFiles(attacher);
+			AttachFiles(new AttachAdapter(mapi));
 			mapi.Send(EmailSubject, exceptionReport);
 		}
 
@@ -93,7 +92,7 @@ private void AttachFiles(IAttach attacher)
 				filesToAttach.Add(ScreenshotTaker.GetImageAsFile(_reportInfo.ScreenshotImage));
 			}
 
-			var existingFilesToAttach = filesToAttach.Where(f => File.Exists(f)).ToList();
+			var existingFilesToAttach = filesToAttach.Where(File.Exists).ToList();
 
 			foreach (var zf in existingFilesToAttach.Where(f => f.EndsWith(".zip"))) {
 				attacher.Attach(zf);		// attach external zip files separately

src/WinFormsDemoApp/DemoAppView.cs

@@ -42,30 +42,30 @@ private static void Throw_CustomMessage_Click(object sender, EventArgs e)
 			{
 				var file1 = Path.GetTempFileName() + "-file1.txt";	
 				var file2 = Path.GetTempFileName() + "-file2.txt";
-				var file3 = Path.GetTempFileName() + "-file3.zip";
+//				var file3 = Path.GetTempFileName() + "-file3.zip";
 
 				File.WriteAllText(file1, "test text file 1");
 				File.WriteAllText(file2, "test text file 2");
-				File.WriteAllText(file3, "test text file 3");
+//				File.WriteAllText(file3, "test text file 3");
 
 				var exceptionReporter = new ExceptionReporter();
 				var config = exceptionReporter.Config;
 
 				config.ShowAssembliesTab = false;
-				config.FilesToAttach = new[] { file1, file2, file3 };
+				config.FilesToAttach = new[] { file1, file2 };// , file3 };
 				config.TakeScreenshot = true;
 
 				//--- Test SMTP
-				//config.MailMethod = ExceptionReportInfo.EmailMethod.SMTP;
-				//config.SmtpPort = 587;
-				//config.SmtpServer= "smtp.gmail.com";
-				//config.SmtpUsername = "<user>";
-				//config.SmtpUseSsl = true;     // NB you'll need to have "Allow less secure apps: ON" if using gmail for this
-				//config.SmtpPassword = "<password>";
-				//config.SmtpFromAddress = "[email protected]";
-				//config.EmailReportAddress = "<user>";
-				//----
-
+				config.MailMethod = ExceptionReportInfo.EmailMethod.SMTP;
+				config.SmtpServer= "smtp.gmail.com";
+				config.SmtpPort = 587;
+				config.SmtpUsername = "<user>";
+				config.SmtpPassword = "<password>";
+				config.SmtpFromAddress = "[email protected]";
+				config.EmailReportAddress = "<emailto>";
+				config.SmtpUseSsl = true;     // NB you'll need to have "Allow less secure apps: ON" if using gmail for this
+				//----
+
 				exceptionReporter.Show("temp files will be attached to the email sent", exception);
 			}
 		}