Merge pull request #63 from tronsha/bugfix/named-slots

tronsha · web-flow · commit 6f19e0999112 · 2020-07-30T12:12:09.000+02:00
Merged without review, because the fix is needed.
diff --git a/src/Utils/TwigBuilder.php b/src/Utils/TwigBuilder.php
@@ -325,7 +325,7 @@ public function createVariableOutput(string $varName, ?string $fallbackVariableN
             return '{{ ' . $varName . '|default(' . $fallbackVariableName . ') }}';
         }
 
-        return '{{ ' . $varName . ' }}';
+        return '{{ ' . $varName . '|default(\'\') }}';
     }
 
     public function prepareBindingOutput(string $value, bool $twigOutput = true): string
diff --git a/tests/fixtures/vue-slot/component-has-default-slot.twig b/tests/fixtures/vue-slot/component-has-default-slot.twig
@@ -1,3 +1,3 @@
 <div class="{{ class|default('') }}" style="{{ style|default('') }}">
-  {{ slot_default }}
+  {{ slot_default|default('') }}
 </div>
diff --git a/tests/fixtures/vue-slot/component-has-named-slots.twig b/tests/fixtures/vue-slot/component-has-named-slots.twig
@@ -0,0 +1,3 @@
+<div class="container {{ class|default('') }}" style="{{ style|default('') }}">
+  {{ slot_button|default('') }}
+</div>
diff --git a/tests/fixtures/vue-slot/component-has-named-slots.vue b/tests/fixtures/vue-slot/component-has-named-slots.vue
@@ -0,0 +1,10 @@
+<template>
+  <div class="container">
+    <slot name="button" />
+  </div>
+</template>
+<script>
+  export default {
+    name: 'BaseLayout',
+  };
+</script>

Original file line number	Diff line number	Diff line change
`@@ -325,7 +325,7 @@ public function createVariableOutput(string $varName, ?string $fallbackVariableN`
`325`	`325`	`return '{{ ' . $varName . '\|default(' . $fallbackVariableName . ') }}';`
`326`	`326`	`}`
`327`	`327`
`328`		`- return '{{ ' . $varName . ' }}';`
	`328`	`+ return '{{ ' . $varName . '\|default(\'\') }}';`
`329`	`329`	`}`
`330`	`330`
`331`	`331`	`public function prepareBindingOutput(string $value, bool $twigOutput = true): string`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+<div class="container {{ class\|default('') }}" style="{{ style\|default('') }}">`
	`2`	`+ {{ slot_button\|default('') }}`
	`3`	`+</div>`