Skip to content

Commit 8a8ae06

Browse files
authored
Merge pull request #38 from Patternslib/fix-style-loader
fix: Webpack style loader.
2 parents 9164405 + ecec3cf commit 8a8ae06

File tree

3 files changed

+17
-15
lines changed

3 files changed

+17
-15
lines changed

webpack/style-inserter.js

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
function style_inserter(el) {
2+
// Insert element at the top of <head>
3+
// Used for injecting CSS via webpack before any other CSS
4+
var first_child = document.head.querySelectorAll("*")[0];
5+
if (first_child) {
6+
document.head.insertBefore(el, first_child);
7+
} else {
8+
document.head.append(el);
9+
}
10+
}
11+
12+
module.exports = style_inserter;

webpack/webpack-helpers.js

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,7 @@
1-
function top_head_insert(el) {
2-
// Insert element at the top of <head>
3-
// Used for injecting CSS via webpack before any other CSS
4-
// Note:
5-
// Keep code compatible with IE11 as long as we support it.
6-
var first_child = document.head.querySelectorAll("*")[0];
7-
if (first_child) {
8-
document.head.insertBefore(el, first_child);
9-
} else {
10-
document.head.append(el);
11-
}
12-
}
1+
// BBB
2+
// TODO: Remove in next major version.
3+
const style_inserter = require("./style-inserter");
134

145
module.exports = {
15-
top_head_insert: top_head_insert,
6+
top_head_insert: style_inserter,
167
};

webpack/webpack.config.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
process.traceDeprecation = true;
22
const webpack = require("webpack");
3-
const webpack_helpers = require("./webpack-helpers");
43

54
// plugins
65
const TerserPlugin = require("terser-webpack-plugin");
@@ -60,7 +59,7 @@ const config_factory = (env, argv, config, babel_include = [], package_json) =>
6059
{
6160
loader: "style-loader",
6261
options: {
63-
insert: webpack_helpers.top_head_insert,
62+
insert: require.resolve("./style-inserter"),
6463
},
6564
},
6665
"css-loader",

0 commit comments

Comments
 (0)