This collapseSmallPayments function has 150+ lines of code, 2 different functions are defined inside it and still some routines that could be separated into a different function (such as the paybutton name extraction). I think in its current state it is hard to read it and hard to mantain it, but refactoring could be done in a separate PR, so I'll open a separate issue for that.
Originally posted by @chedieck in #978 (review)
This
collapseSmallPaymentsfunction has 150+ lines of code, 2 different functions are defined inside it and still some routines that could be separated into a different function (such as the paybutton name extraction). I think in its current state it is hard to read it and hard to mantain it, but refactoring could be done in a separate PR, so I'll open a separate issue for that.Originally posted by @chedieck in #978 (review)