You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
The PepperDash.Essentials.Core GenericCommunicationMonitor polling mechanism does not start polling unless the GenericCommunicationMonitor client is of type iSocketStatus. A device with a com or udp communication method type does not trigger BeginPolling() within the GenericCommunicationMonitor subsequently not triggering the constructor item with signature object Action pollAction or pollString.
Describe the solution you'd like
Recommend removing BeginPolling() out of the if (!IsSocket) forcing BeginPolling() no matter if the client type is of iSocketStatus or not. This allows EPI devices to utilize the GenericCommunicationMonitor constructor object Action pollAction or pollString to implement polling, independent of the control method defined.
Describe alternatives you've considered
Change the BeginPolling() method accessor to include public override. However, I like the solution above better.
Additional context
None
The text was updated successfully, but these errors were encountered:
@jonnyarndt go ahead and remove the if(!IsSocket) conditional around the BeginPolling() call inside the Start() method.
While you're at it, I would also recommend inside the Start() method adding a line to deregister for the client.BytesReceived and client.TextReceived events before registering. Otherwise, calling Start() multiple times will cause multiple event registrations:
Is your feature request related to a problem? Please describe.
The PepperDash.Essentials.Core
GenericCommunicationMonitor
polling mechanism does not start polling unless theGenericCommunicationMonitor
client is of typeiSocketStatus
. A device with acom
orudp
communication method type does not triggerBeginPolling()
within theGenericCommunicationMonitor
subsequently not triggering the constructor item with signature objectAction pollAction
orpollString
.Describe the solution you'd like
Recommend removing
BeginPolling()
out of theif (!IsSocket)
forcingBeginPolling()
no matter if the client type is ofiSocketStatus
or not. This allows EPI devices to utilize theGenericCommunicationMonitor
constructor objectAction pollAction
orpollString
to implement polling, independent of the control method defined.Describe alternatives you've considered
Change the
BeginPolling()
method accessor to includepublic override
. However, I like the solution above better.Additional context
None
The text was updated successfully, but these errors were encountered: