[$40 BOUNTY] [Python] Add diagnostic redaction regression tests

[Peter7896]

Bounty: $40 (LT)

Area: build.py, diagnostic/, tests/

Current state: build.py generates diagnostic metadata and encrypted .logd artifacts, but there is no focused regression coverage that protects the redaction and path-normalization contract across Windows and Unix-like hosts.

What's needed: Add deterministic tests or helpers that validate diagnostic redaction, artifact pairing, and repository-relative path reporting without relying on live services.

Acceptance criteria:

• Validate that diagnostic metadata reports artifact paths as repository-relative / paths.
• Assert local home, repo, temp paths, machine names, and usernames are not leaked in diagnostic metadata.
• Confirm the .logd reference in JSON matches a generated encrypted artifact in diagnostic/.
• Fail clearly when the JSON is missing, the .logd artifact is missing, or the pair is mismatched.
• Keep the coverage deterministic on Windows and Unix-like hosts.

Required validation:

• Run python3 build.py
• Include the generated diagnostic .logd artifact from diagnostic/build-XXX.logd; also include diagnostic/build-XXX.json if present
• Use .github/pull_request_template.md for your submission

Tracker note: This issue is opened for the upstream LT bounty tracker; bounty eligibility and payout are determined by upstream review, merge, and tracker rules.

[Buyurgutdev]

/attempt #1

Plan: add deterministic Python regression coverage for diagnostic redaction and artifact pairing. I will inspect build.py and existing diagnostic output, add helper/test coverage that verifies repository-relative / paths, checks that local home/repo/temp/user/machine identifiers do not leak into diagnostic metadata, validates JSON-to-.logd pairing, run the focused tests and python3 build.py, and submit a scoped PR with the required diagnostic artifacts.

[fengyangxxx]

/attempt #1

[BERT70293]

submitted PR #4 — 15 tests covering path reporting, PII redaction, artifact pairing, error handling, and cross-platform consistency. all passing.

[Peter7896]

Thanks for the submissions. For this issue, the reviewable unit should stay focused on diagnostic redaction/regression coverage only.

I see PRs that mention this issue. A PR that bundles this with the protocol codec issue is not ready to forward as-is, because the upstream tracker needs one clearly scoped change per bounty. A bounty-ready PR also needs the exact script-generated diagnostic artifacts from python3 build.py: a matching diagnostic/build-*.json and diagnostic/build-*.logd pair in the changed files.

I will review the single-purpose diagnostic-redaction PR first. Please keep any follow-up PR scoped to this issue and avoid hand-editing diagnostic output.

[bilalabsh]

Submitted PR #7 for this issue.

Adds regression tests around diagnostic metadata in build.py — repo-relative path reporting, PII redaction (home/repo/temp paths, username, hostname), JSON ↔ .logd artifact pairing, and clear failures when metadata or artifacts are missing or mismatched. Also includes helpers in build.py to enforce the redaction and path-normalization contract without relying on live services.

14 tests, all passing locally:

python3 -m unittest tests.test_diagnostic_redaction -v
Also ran python3 build.py and committed the diagnostic bundle (diagnostic/build-6b3111c3.logd + matching .json) for review.

Ready for upstream review when you have a chance.

[thanhle74]

Claiming this bounty for the diagnostic redaction regression tests.