Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: BrAPI field import germplasm attributes not imported in some cases #1055

Open
nickpalladino opened this issue Oct 2, 2024 · 1 comment
Assignees

Comments

@nickpalladino
Copy link
Collaborator

nickpalladino commented Oct 2, 2024

Description

As part of the BrAPI field import process a germplasm search call is made and the results are used to populate the pedigree and synonyms attributes for display on the collect page. When the search call responds with a searchResultDbId and a GET call is made to get the results by Field Book, if the results are not ready by the time the first call is made they will not be imported. This seems to be because the retry logic in Field Book is not handling that case properly and is only making the single request. Problem seems to be in the BrAPIServiceV2::executeBrapiSearch while loop exiting before it should.

Expected behavior

No response

Field Book version

No response

@chaneylc
Copy link
Member

chaneylc commented Dec 4, 2024

@nickpalladino on our latest version we are testing out a new brapi import, can you test to see if the problem still occurs? You can enable it in the Settings/Experimental/New BrAPI Import UI. Currently that implementation uses the germplasmGetAsync call with the chosen study db id, if that method doesn't work for you I can implement the search case. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

3 participants