Replies: 2 comments
-
|
I think it is a good option. Here my thoughts:
|
Beta Was this translation helpful? Give feedback.
0 replies
-
|
addressed in pr #401 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
After the recent header decoupling work, the standard header looks consistent across layouts, but the left-hand side gets visually heavy when the sidebar is enabled, it ends up holding [Menu button with label] + [Logo] + [Company name], while the right has fewer elements. I'd like to propose a small layout adjustment and gather feedback before opening a PR.
Current state
[Menu] [Logo] [Company name] … [Event name + dates] … [Logout]
Proposed layout
Specifically:
Menuicon, ~32×32). The action is universally recognised; the label is noise once users know where it is.Why
Open questions
lg+breakpoints. Any concerns with that interacting with custom branding logos (centred / right-aligned variants)?controlsStyle === 'classic'(filters inline)? Today it only renders when sidebar is on, but worth confirming.If there's broad agreement I'll open a PR following the same pattern as the recent decoupling work.
Beta Was this translation helpful? Give feedback.
All reactions