From 33855434dd1d64fec737cb7c77786a52bd8bc3a3 Mon Sep 17 00:00:00 2001
From: theov <theovilardo@gmail.com>
Date: Tue, 19 May 2026 18:22:38 -0300
Subject: [PATCH] refactor: externalize Telegram API credentials to BuildConfig

Removes hardcoded Telegram API credentials from `TelegramClientManager` and moves them to `BuildConfig` fields populated from `local.properties`. This change also updates the device model and version metadata sent to the Telegram API.

- Added `TELEGRAM_API_ID` and `TELEGRAM_API_HASH` fields to `build.gradle.kts`.
- Updated `TelegramClientManager` to use `BuildConfig` for API identity and application version.
- Changed the Telegram client `deviceModel` from the physical device model to "PixelPlayer Instance".
- Implemented `local.properties` parsing in the app-level Gradle script to manage sensitive credentials.
---
 app/build.gradle.kts                                 | 12 ++++++++++++
 .../pixelplay/data/telegram/TelegramClientManager.kt |  9 +++++----
 2 files changed, 17 insertions(+), 4 deletions(-)

diff --git a/app/build.gradle.kts b/app/build.gradle.kts
index d29493347..f0e7e313b 100644
--- a/app/build.gradle.kts
+++ b/app/build.gradle.kts
@@ -18,6 +18,13 @@ val keystoreProperties = Properties().apply {
     }
 }
 
+val localProperties = Properties().apply {
+    val propFile = rootProject.file("local.properties")
+    if (propFile.exists()) {
+        propFile.inputStream().use { load(it) }
+    }
+}
+
 val enableAbiSplits = providers.gradleProperty("pixelplay.enableAbiSplits")
     .getOrElse("true")
     .toBoolean()
@@ -66,6 +73,11 @@ android {
         versionName = (project.findProperty("APP_VERSION_NAME") as? String) ?: "1.0.0"
 
         testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
+
+        val telegramApiId = localProperties.getProperty("TELEGRAM_API_ID") ?: ""
+        val telegramApiHash = localProperties.getProperty("TELEGRAM_API_HASH") ?: ""
+        buildConfigField("int", "TELEGRAM_API_ID", telegramApiId.ifEmpty { "0" })
+        buildConfigField("String", "TELEGRAM_API_HASH", "\"$telegramApiHash\"")
     }
 
     signingConfigs {
diff --git a/app/src/main/java/com/theveloper/pixelplay/data/telegram/TelegramClientManager.kt b/app/src/main/java/com/theveloper/pixelplay/data/telegram/TelegramClientManager.kt
index cbb13f8ab..d85ac81ab 100644
--- a/app/src/main/java/com/theveloper/pixelplay/data/telegram/TelegramClientManager.kt
+++ b/app/src/main/java/com/theveloper/pixelplay/data/telegram/TelegramClientManager.kt
@@ -1,6 +1,7 @@
 package com.theveloper.pixelplay.data.telegram
 
 import android.content.Context
+import com.theveloper.pixelplay.BuildConfig
 import dagger.hilt.android.qualifiers.ApplicationContext
 import kotlinx.coroutines.flow.MutableSharedFlow
 import kotlinx.coroutines.flow.MutableStateFlow
@@ -108,12 +109,12 @@ class TelegramClientManager @Inject constructor(
                     true, // useChatInfoDatabase
                     true, // useMessageDatabase
                     false, // useSecretChats
-                    2040, // apiId
-                    "b18441a1ff607e10a989891a5462e627", // apiHash
+                    BuildConfig.TELEGRAM_API_ID,
+                    BuildConfig.TELEGRAM_API_HASH,
                     "en", // systemLanguageCode
-                    android.os.Build.MODEL, // deviceModel
+                    "PixelPlayer Instance", // deviceModel
                     android.os.Build.VERSION.RELEASE, // systemVersion
-                    "1.0" // applicationVersion
+                    BuildConfig.VERSION_NAME
                 ), defaultHandler)
             }
             is TdApi.AuthorizationStateWaitPhoneNumber -> {