Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API needs to buffer Geolocation changes between requests #31

Open
robertmclaws opened this issue Aug 31, 2016 · 2 comments
Open

API needs to buffer Geolocation changes between requests #31

robertmclaws opened this issue Aug 31, 2016 · 2 comments
Assignees
Labels
Milestone

Comments

@robertmclaws
Copy link

I'm not sure if the Signature code is doing this right now, but the real game samples GPS location every second, and stores it in a buffer to be sent the next time GetMapObjects is called. We need to do the same thing, either at the ApiClient or GameService level.

@robertmclaws robertmclaws added this to the PoGo 2.0 milestone Aug 31, 2016
@robertmclaws robertmclaws self-assigned this Aug 31, 2016
@WallyCZ
Copy link
Contributor

WallyCZ commented Aug 31, 2016

It's already done in DeviceInfo (PokemonGo_UWP.Utils.DeviceInfosIOS) class in main app. I don't think that Api should collect it, it is responsibility of the app. And if we want emulate more devices, this needs to stay in this DeviceInfo class, because these data are different on different devices.

@robertmclaws
Copy link
Author

Having started to import the existing DeviceInfo code to the new GameServices, it is pulling info directly from the legacy GameClient class, which is not going to be possible moving forward. The relevant code will need to be moved to the new LocationService, which will combine buffer the location data until it is ready to be dumped into the Signature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants