-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accesibility thread #100
Comments
Thanks for your issue. Did you create code to fix these? |
Yes I did, and I will propose three pull request (corresponding to the issues described here). |
…uttons * adding role="presentation" * get an unique key for the differents propositions inside a likert scale question (basically a simple enumeration) * link headers and radio buttons with this unique key
* create string 'requiredfield' * put an 'alt' attribute inside the '<img>' tags * add a legend (new string) to inform that the required fields are annoted with an asterisk * change an image_url (deprecated) to a pix_url
* fix nearly existing link between textarea & question * update required field in question_container template (should have been in commit "Issue PoetOS#100 - Required fields") * update rate template (should have been in commit "Issue PoetOS#100 - likert scale")
Yeah "noon" ^^' So here is the work we've done. I have mixed some of the commit :( There is also a last branch where I putted the changes that didn't make sense in the other branches : #104 I would like to say that this is the first time we participate at a community plugin and if you could give me some advices about the sharing process (obviously apart from the mixed branches for wich I already apologize) it would be nice :) I hope that despite the dirtiness, you will find this helpfull. Regards, |
Thanks for that. I will review and let you know about any issues. I will also let you know about any way to participate easier. Thanks for the contribution! |
Hi,
A client recently asked us to improve the accessibility of their moodle. They did an audit of their platform (I think its was following the RGAA 2.2 or 3.0 standart) and we had to work on the problems they puted in light.
Since this moodle platform do use your plugin (great work by the way :D ), we though it might be a good idea to share our work with you and the community.
So here is some description of the problems we've faced and I will provide the pull requests in a near future.
1. Likert scale - make relation between grid header title and each response
The idea was to link the header with every
<input type="radio">
of the same column.To do so, we added an id for every header (named q<question_number>_resp<response_number>) and we used the HTML property
aria-labelledby
to do the link.We also added a
role="presentation"
to the table.So the desired HTML looks like this :
Here is an ugly output of a likert scale question :
2. Required fields
It seems that there was no legend saying that the required fields were marked by a red asterisk. So we had to add one.
Since the red asterisks are
<img>
tags, the HTML tags have to contain thealt
attribute.3. essay box - make relation between label and id
The HTML for the essay box was like this :
You easily see that the id of the textarea is close but not equal to the id given in the
for
attribute of the<label>
tagThe text was updated successfully, but these errors were encountered: