Upgrade takes too long

[ewout]

I use version 3.7.4 and mariadb. I encountered again a problem with the upgrade from M3.6 to M3.7. There are many queries of type

SELECT * FROM mdl_questionnaire_response_rank WHERE question_id = '229924'

which individually don't take too much time (maybe 0.1 or 0.2 seconds?), but we have 992876 entries in that table (is that a lot?). A 10^5 seconds is too long...

It has been a couple of hours now and no sign of terminating.

[danmarsden]

Looking at that block of code I wonder if replacing it with a sql command like this might be better:

update mdl_questionnaire_question_type SET typeid = id where typeid = 0

[danmarsden]

(But - I haven't looked closely at the code... so at your own risk etc...)

[ewout]

The upgrade finished, it took 168 min. I upgraded another site (with version3.7.3, but the rate.php code hasn't really changed in 3.7.4) without problems, but that site had only 36000 rows in mdl_questionnaire_response_rank, a factor 20 less.